-
Notifications
You must be signed in to change notification settings - Fork 467
chore(profiling): move echion to dd-trace-py #15136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
991be14 to
d22f7f9
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 249 ± 3 ms. The average import time from base is: 252 ± 3 ms. The import time difference between this PR and base is: -3.1 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
9ed70c1 to
edf6a25
Compare
eb048a2 to
08c227e
Compare
Performance SLOsComparing candidate kowalski/echion-to-dd-trace-py (539d3dd) with baseline main (7d7d92e) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.279µs (SLO: <10.000µs 📉 -57.2%) vs baseline: +1.1% Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.094µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +1.0% Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.1% ✅ ospathjoin_aspectTime: ✅ 7.182µs (SLO: <10.000µs 📉 -28.2%) vs baseline: 📈 +17.7% Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +5.3% ✅ ospathjoin_noaspectTime: ✅ 2.290µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.2% Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.484µs (SLO: <10.000µs 📉 -65.2%) vs baseline: -0.6% Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +5.3% ✅ ospathnormcase_noaspectTime: ✅ 0.575µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.5% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +5.3% ✅ ospathsplit_aspectTime: ✅ 4.869µs (SLO: <10.000µs 📉 -51.3%) vs baseline: +0.2% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 1.599µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.5% Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 3.684µs (SLO: <10.000µs 📉 -63.2%) vs baseline: -0.8% Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.709µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +1.1% Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +5.4% ✅ ospathsplitext_aspectTime: ✅ 4.536µs (SLO: <10.000µs 📉 -54.6%) vs baseline: -1.1% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +5.5% ✅ ospathsplitext_noaspectTime: ✅ 1.397µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +0.7% Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.1% 🟡 Near SLO Breach (7 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.469ms (SLO: <22.300ms -8.2%) vs baseline: -0.1% Memory: ✅ 66.158MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ exception-replay-enabledTime: ✅ 1.341ms (SLO: <1.450ms -7.5%) vs baseline: +0.2% Memory: ✅ 64.324MB (SLO: <67.000MB -4.0%) vs baseline: +5.1% ✅ iastTime: ✅ 20.474ms (SLO: <22.250ms -8.0%) vs baseline: +0.3% Memory: ✅ 66.218MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.2% ✅ profilerTime: ✅ 15.503ms (SLO: <16.550ms -6.3%) vs baseline: +0.2% Memory: ✅ 54.051MB (SLO: <54.500MB 🟡 -0.8%) vs baseline: +5.1% ✅ resource-renamingTime: ✅ 20.510ms (SLO: <21.750ms -5.7%) vs baseline: -0.4% Memory: ✅ 66.159MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ span-code-originTime: ✅ 25.413ms (SLO: <28.200ms -9.9%) vs baseline: +0.2% Memory: ✅ 66.982MB (SLO: <69.500MB -3.6%) vs baseline: +4.4% ✅ tracerTime: ✅ 20.433ms (SLO: <21.750ms -6.1%) vs baseline: -0.2% Memory: ✅ 66.129MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-and-profilerTime: ✅ 22.629ms (SLO: <23.500ms -3.7%) vs baseline: -0.4% Memory: ✅ 67.585MB (SLO: <68.000MB 🟡 -0.6%) vs baseline: +5.1% ✅ tracer-dont-create-db-spansTime: ✅ 19.353ms (SLO: <21.500ms -10.0%) vs baseline: +0.2% Memory: ✅ 66.247MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.2% ✅ tracer-minimalTime: ✅ 16.648ms (SLO: <17.500ms -4.9%) vs baseline: +0.4% Memory: ✅ 65.913MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.547ms (SLO: <21.750ms -5.5%) vs baseline: +0.2% Memory: ✅ 67.712MB (SLO: <72.500MB -6.6%) vs baseline: +5.0% ✅ tracer-no-cachesTime: ✅ 18.429ms (SLO: <19.650ms -6.2%) vs baseline: -0.1% Memory: ✅ 66.159MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.808ms (SLO: <20.100ms -6.4%) vs baseline: +0.5% Memory: ✅ 65.805MB (SLO: <67.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ tracer-no-middlewareTime: ✅ 20.159ms (SLO: <21.500ms -6.2%) vs baseline: -0.1% Memory: ✅ 66.109MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.310ms (SLO: <22.000ms -7.7%) vs baseline: +0.3% Memory: ✅ 66.218MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.1% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.226ms (SLO: <19.850ms -8.2%) vs baseline: +1.2% Memory: ✅ 66.158MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.023ms (SLO: <19.400ms -7.1%) vs baseline: -0.2% Memory: ✅ 66.114MB (SLO: <66.500MB 🟡 -0.6%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 18.094ms (SLO: <19.450ms -7.0%) vs baseline: +0.5% Memory: ✅ 65.861MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +5.2% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.069ms (SLO: <2.300ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 52.652MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.4% ✅ errortracking-enabled-userTime: ✅ 2.068ms (SLO: <2.250ms -8.1%) vs baseline: ~same Memory: ✅ 52.671MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.3% ✅ tracer-enabledTime: ✅ 2.082ms (SLO: <2.300ms -9.5%) vs baseline: +0.5% Memory: ✅ 52.691MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.1% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.598ms (SLO: <4.750ms -3.2%) vs baseline: +0.2% Memory: ✅ 62.331MB (SLO: <65.000MB -4.1%) vs baseline: +5.1% ✅ appsec-postTime: ✅ 6.630ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: +0.3% Memory: ✅ 62.326MB (SLO: <65.000MB -4.1%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 4.607ms (SLO: <4.750ms -3.0%) vs baseline: +0.7% Memory: ✅ 62.348MB (SLO: <65.000MB -4.1%) vs baseline: +5.0% ✅ debuggerTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 45.302MB (SLO: <47.000MB -3.6%) vs baseline: +5.3% ✅ iast-getTime: ✅ 1.855ms (SLO: <2.000ms -7.3%) vs baseline: -0.4% Memory: ✅ 42.169MB (SLO: <49.000MB 📉 -13.9%) vs baseline: +5.3% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -9.0%) vs baseline: -0.2% Memory: ✅ 46.704MB (SLO: <47.000MB 🟡 -0.6%) vs baseline: +5.2% ✅ resource-renamingTime: ✅ 3.376ms (SLO: <3.650ms -7.5%) vs baseline: +0.3% Memory: ✅ 52.644MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ tracerTime: ✅ 3.357ms (SLO: <3.650ms -8.0%) vs baseline: +0.2% Memory: ✅ 52.469MB (SLO: <53.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.353ms (SLO: <3.650ms -8.1%) vs baseline: -0.1% Memory: ✅ 54.114MB (SLO: <60.000MB -9.8%) vs baseline: +4.9% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.960ms (SLO: <4.200ms -5.7%) vs baseline: -1.0% Memory: ✅ 62.443MB (SLO: <66.000MB -5.4%) vs baseline: +5.2% ✅ iast-enabledTime: ✅ 2.430ms (SLO: <2.800ms 📉 -13.2%) vs baseline: -0.6% Memory: ✅ 59.179MB (SLO: <60.000MB 🟡 -1.4%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 2.063ms (SLO: <2.250ms -8.3%) vs baseline: +0.4% Memory: ✅ 52.652MB (SLO: <54.500MB -3.4%) vs baseline: +5.3% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 308.893ms (SLO: <320.950ms -3.8%) vs baseline: +0.1% Memory: ✅ 32.735MB (SLO: <34.500MB -5.1%) vs baseline: +5.0% ✅ deep-profiledTime: ✅ 328.592ms (SLO: <359.150ms -8.5%) vs baseline: +0.4% Memory: ✅ 38.825MB (SLO: <39.000MB 🟡 -0.4%) vs baseline: +9.3% ✅ mediumTime: ✅ 7.007ms (SLO: <7.400ms -5.3%) vs baseline: ~same Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +5.1% ✅ shallowTime: ✅ 0.943ms (SLO: <1.050ms 📉 -10.2%) vs baseline: +0.2% Memory: ✅ 31.988MB (SLO: <34.000MB -5.9%) vs baseline: +5.1% 🟡 span - 26/26✅ add-eventTime: ✅ 19.954ms (SLO: <22.500ms 📉 -11.3%) vs baseline: +0.6% Memory: ✅ 48.486MB (SLO: <53.000MB -8.5%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 91.735ms (SLO: <93.500ms 🟡 -1.9%) vs baseline: +2.4% Memory: ✅ 735.425MB (SLO: <961.000MB 📉 -23.5%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 147.547ms (SLO: <155.000ms -4.8%) vs baseline: +0.8% Memory: ✅ 735.918MB (SLO: <962.500MB 📉 -23.5%) vs baseline: +4.8% ✅ get-contextTime: ✅ 18.346ms (SLO: <20.500ms 📉 -10.5%) vs baseline: ~same Memory: ✅ 47.304MB (SLO: <53.000MB 📉 -10.7%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 18.659ms (SLO: <20.500ms -9.0%) vs baseline: +0.6% Memory: ✅ 47.253MB (SLO: <53.000MB 📉 -10.8%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 37.713ms (SLO: <40.000ms -5.7%) vs baseline: +0.9% Memory: ✅ 41.717MB (SLO: <53.000MB 📉 -21.3%) vs baseline: +5.0% ✅ set-statusTime: ✅ 20.229ms (SLO: <22.000ms -8.1%) vs baseline: +0.7% Memory: ✅ 47.327MB (SLO: <53.000MB 📉 -10.7%) vs baseline: +5.1% ✅ startTime: ✅ 18.165ms (SLO: <20.500ms 📉 -11.4%) vs baseline: +0.4% Memory: ✅ 47.262MB (SLO: <53.000MB 📉 -10.8%) vs baseline: +4.9% ✅ start-finishTime: ✅ 50.544ms (SLO: <52.500ms -3.7%) vs baseline: -0.3% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +5.1% ✅ start-finish-telemetryTime: ✅ 52.418ms (SLO: <54.500ms -3.8%) vs baseline: +0.5% Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +5.0% ✅ start-finish-traceid128Time: ✅ 54.387ms (SLO: <57.000ms -4.6%) vs baseline: +1.0% Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +5.0% ✅ start-traceid128Time: ✅ 18.643ms (SLO: <22.500ms 📉 -17.1%) vs baseline: ~same Memory: ✅ 47.381MB (SLO: <53.000MB 📉 -10.6%) vs baseline: +5.3% ✅ update-nameTime: ✅ 18.720ms (SLO: <22.000ms 📉 -14.9%) vs baseline: +0.4% Memory: ✅ 47.880MB (SLO: <53.000MB -9.7%) vs baseline: +5.0%
|
08c227e to
679db40
Compare
Description
Testing
Risks
Additional Notes