-
Notifications
You must be signed in to change notification settings - Fork 467
fix(core): use unpatched lock from forksafe module #15151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 243 ± 3 ms. The average import time from base is: 247 ± 5 ms. The import time difference between this PR and base is: -4.4 ± 0.2 ms. Import time breakdownThe following import paths have appeared:
|
Performance SLOsComparing candidate taegyunkim/forksafe-lock (4b02c9d) with baseline main (7bc20af) 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.520ms (SLO: <22.300ms -8.0%) vs baseline: +0.3% Memory: ✅ 66.154MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.346ms (SLO: <1.450ms -7.2%) vs baseline: +0.6% Memory: ✅ 64.487MB (SLO: <67.000MB -3.8%) vs baseline: +5.1% ✅ iastTime: ✅ 20.527ms (SLO: <22.250ms -7.7%) vs baseline: +0.4% Memory: ✅ 66.166MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.564ms (SLO: <16.550ms -6.0%) vs baseline: +0.2% Memory: ✅ 54.052MB (SLO: <54.500MB 🟡 -0.8%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 20.543ms (SLO: <21.750ms -5.6%) vs baseline: +0.2% Memory: ✅ 66.192MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 25.410ms (SLO: <28.200ms -9.9%) vs baseline: +1.7% Memory: ✅ 67.287MB (SLO: <69.500MB -3.2%) vs baseline: +4.8% ✅ tracerTime: ✅ 20.573ms (SLO: <21.750ms -5.4%) vs baseline: +0.5% Memory: ✅ 66.110MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-and-profilerTime: ✅ 22.686ms (SLO: <23.500ms -3.5%) vs baseline: ~same Memory: ✅ 67.865MB (SLO: <68.000MB 🟡 -0.2%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.313ms (SLO: <21.500ms 📉 -10.2%) vs baseline: +0.1% Memory: ✅ 66.162MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.608ms (SLO: <17.500ms -5.1%) vs baseline: -0.6% Memory: ✅ 66.050MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 20.522ms (SLO: <21.750ms -5.6%) vs baseline: +0.2% Memory: ✅ 67.626MB (SLO: <72.500MB -6.7%) vs baseline: +4.6% ✅ tracer-no-cachesTime: ✅ 18.492ms (SLO: <19.650ms -5.9%) vs baseline: +0.6% Memory: ✅ 66.115MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.790ms (SLO: <20.100ms -6.5%) vs baseline: +0.3% Memory: ✅ 66.091MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.207ms (SLO: <21.500ms -6.0%) vs baseline: +0.2% Memory: ✅ 66.105MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.335ms (SLO: <22.000ms -7.6%) vs baseline: +0.2% Memory: ✅ 66.150MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.132ms (SLO: <19.850ms -8.7%) vs baseline: +0.6% Memory: ✅ 65.997MB (SLO: <66.500MB 🟡 -0.8%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 18.046ms (SLO: <19.400ms -7.0%) vs baseline: ~same Memory: ✅ 66.067MB (SLO: <66.500MB 🟡 -0.7%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.227ms (SLO: <19.450ms -6.3%) vs baseline: +1.5% Memory: ✅ 66.092MB (SLO: <66.500MB 🟡 -0.6%) vs baseline: +5.0% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.066ms (SLO: <2.300ms 📉 -10.2%) vs baseline: -0.1% Memory: ✅ 52.844MB (SLO: <53.500MB 🟡 -1.2%) vs baseline: +5.3% ✅ errortracking-enabled-userTime: ✅ 2.063ms (SLO: <2.250ms -8.3%) vs baseline: -0.2% Memory: ✅ 52.861MB (SLO: <53.500MB 🟡 -1.2%) vs baseline: +5.3% ✅ tracer-enabledTime: ✅ 2.076ms (SLO: <2.300ms -9.7%) vs baseline: +0.3% Memory: ✅ 52.491MB (SLO: <53.500MB 🟡 -1.9%) vs baseline: +4.6% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.551ms (SLO: <4.750ms -4.2%) vs baseline: +0.4% Memory: ✅ 62.422MB (SLO: <65.000MB -4.0%) vs baseline: +5.2% ✅ appsec-postTime: ✅ 6.615ms (SLO: <6.750ms 🟡 -2.0%) vs baseline: +0.3% Memory: ✅ 62.462MB (SLO: <65.000MB -3.9%) vs baseline: +5.1% ✅ appsec-telemetryTime: ✅ 4.536ms (SLO: <4.750ms -4.5%) vs baseline: -0.1% Memory: ✅ 62.461MB (SLO: <65.000MB -3.9%) vs baseline: +5.2% ✅ debuggerTime: ✅ 1.831ms (SLO: <2.000ms -8.5%) vs baseline: +0.2% Memory: ✅ 45.436MB (SLO: <47.000MB -3.3%) vs baseline: +5.5% ✅ iast-getTime: ✅ 1.830ms (SLO: <2.000ms -8.5%) vs baseline: +0.1% Memory: ✅ 42.309MB (SLO: <49.000MB 📉 -13.7%) vs baseline: +5.1% ✅ profilerTime: ✅ 1.878ms (SLO: <2.100ms 📉 -10.6%) vs baseline: ~same Memory: ✅ 46.911MB (SLO: <47.000MB 🟡 -0.2%) vs baseline: +5.3% ✅ resource-renamingTime: ✅ 3.322ms (SLO: <3.650ms -9.0%) vs baseline: +0.8% Memory: ✅ 52.750MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.294ms (SLO: <3.650ms -9.7%) vs baseline: -0.1% Memory: ✅ 52.750MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +5.1% ✅ tracer-nativeTime: ✅ 3.300ms (SLO: <3.650ms -9.6%) vs baseline: +0.4% Memory: ✅ 54.236MB (SLO: <60.000MB -9.6%) vs baseline: +5.1% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.968ms (SLO: <4.200ms -5.5%) vs baseline: -0.5% Memory: ✅ 62.621MB (SLO: <66.000MB -5.1%) vs baseline: +5.1% ✅ iast-enabledTime: ✅ 2.439ms (SLO: <2.800ms 📉 -12.9%) vs baseline: -0.3% Memory: ✅ 59.408MB (SLO: <60.000MB 🟡 -1.0%) vs baseline: +5.3% ✅ tracer-enabledTime: ✅ 2.061ms (SLO: <2.250ms -8.4%) vs baseline: -0.2% Memory: ✅ 52.516MB (SLO: <54.500MB -3.6%) vs baseline: +4.5% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 308.633ms (SLO: <320.950ms -3.8%) vs baseline: -0.3% Memory: ✅ 32.775MB (SLO: <34.500MB -5.0%) vs baseline: +4.9% ✅ deep-profiledTime: ✅ 327.914ms (SLO: <359.150ms -8.7%) vs baseline: -0.1% Memory: ✅ 38.308MB (SLO: <39.000MB 🟡 -1.8%) vs baseline: +6.6% ✅ mediumTime: ✅ 6.991ms (SLO: <7.400ms -5.5%) vs baseline: -0.4% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +5.2% ✅ shallowTime: ✅ 0.940ms (SLO: <1.050ms 📉 -10.5%) vs baseline: ~same Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +4.8%
|
|
I'll add a test to catch scenarios like this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a new test that shows this scenario is fixed with the change?
Description
From a recent profiling escalation, we've seen a flamegraph where forksafe lock is calling into patched profiling lock.

The library used in above flamegraph is version 3.17.0.
From the leaf frame
dd-trace-py/ddtrace/internal/service.py
Lines 57 to 61 in 7451e84
self._service_lockis declared as aforksafe.Lock()dd-trace-py/ddtrace/internal/service.py
Line 33 in 7451e84
Testing
Risks
Additional Notes