-
Notifications
You must be signed in to change notification settings - Fork 467
chore(profiling): remove deprecated env var, DD_PROFILING_API_TIMEOUT
#15169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.0-breaking-changes
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 239 ± 3 ms. The average import time from base is: 242 ± 3 ms. The import time difference between this PR and base is: -3.4 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate taegyunkim/deprecate-api-timeout (aea4125) with baseline 4.0-breaking-changes (1f48e2c) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.254µs (SLO: <10.000µs 📉 -57.5%) vs baseline: -0.5% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +5.2% ✅ ospathbasename_noaspectTime: ✅ 1.085µs (SLO: <10.000µs 📉 -89.2%) vs baseline: +0.4% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.119µs (SLO: <10.000µs 📉 -38.8%) vs baseline: -0.3% Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 2.313µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +1.2% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 4.135µs (SLO: <10.000µs 📉 -58.7%) vs baseline: 📈 +16.9% Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +4.6% ✅ ospathnormcase_noaspectTime: ✅ 0.575µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +1.1% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +5.1% ✅ ospathsplit_aspectTime: ✅ 5.357µs (SLO: <10.000µs 📉 -46.4%) vs baseline: +9.6% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ ospathsplit_noaspectTime: ✅ 1.593µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.1% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 3.738µs (SLO: <10.000µs 📉 -62.6%) vs baseline: -0.2% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.698µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.2% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.602µs (SLO: <10.000µs 📉 -54.0%) vs baseline: -0.8% Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 1.394µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +1.7% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +5.0% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.160µs (SLO: <20.000µs 📉 -84.2%) vs baseline: +1.4% Memory: ✅ 32.047MB (SLO: <34.000MB -5.7%) vs baseline: +5.1% ✅ 1-count-metrics-100-timesTime: ✅ 205.261µs (SLO: <220.000µs -6.7%) vs baseline: +0.7% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +4.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.469µs (SLO: <20.000µs 📉 -82.7%) vs baseline: +1.0% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 219.591µs (SLO: <220.000µs 🟡 -0.2%) vs baseline: ~same Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.488µs (SLO: <20.000µs 📉 -87.6%) vs baseline: 📈 +11.7% Memory: ✅ 32.027MB (SLO: <34.000MB -5.8%) vs baseline: +5.2% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.095µs (SLO: <150.000µs -8.6%) vs baseline: +0.5% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +5.1% ✅ 1-rate-metric-1-timesTime: ✅ 3.216µs (SLO: <20.000µs 📉 -83.9%) vs baseline: -0.3% Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 220.396µs (SLO: <250.000µs 📉 -11.8%) vs baseline: +1.3% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +5.1% ✅ 100-count-metrics-100-timesTime: ✅ 20.432ms (SLO: <22.000ms -7.1%) vs baseline: +1.4% Memory: ✅ 32.047MB (SLO: <34.000MB -5.7%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.254ms (SLO: <2.300ms 🟡 -2.0%) vs baseline: +1.2% Memory: ✅ 32.047MB (SLO: <34.000MB -5.7%) vs baseline: +5.1% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.410ms (SLO: <1.550ms -9.0%) vs baseline: +0.5% Memory: ✅ 32.047MB (SLO: <34.000MB -5.7%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.200ms (SLO: <2.550ms 📉 -13.7%) vs baseline: -0.4% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +5.1% ✅ flush-1-metricTime: ✅ 4.746µs (SLO: <20.000µs 📉 -76.3%) vs baseline: ~same Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +4.6% ✅ flush-100-metricsTime: ✅ 175.961µs (SLO: <250.000µs 📉 -29.6%) vs baseline: -0.6% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.127ms (SLO: <2.500ms 📉 -14.9%) vs baseline: -0.5% Memory: ✅ 32.794MB (SLO: <34.500MB -4.9%) vs baseline: +4.7% 🟡 Near SLO Breach (7 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.426ms (SLO: <22.300ms -8.4%) vs baseline: ~same Memory: ✅ 66.096MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.7% ✅ exception-replay-enabledTime: ✅ 1.343ms (SLO: <1.450ms -7.4%) vs baseline: ~same Memory: ✅ 64.289MB (SLO: <67.000MB -4.0%) vs baseline: +4.8% ✅ iastTime: ✅ 20.418ms (SLO: <22.250ms -8.2%) vs baseline: -0.3% Memory: ✅ 66.120MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.578ms (SLO: <16.550ms -5.9%) vs baseline: +0.3% Memory: ✅ 53.967MB (SLO: <54.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 20.506ms (SLO: <21.750ms -5.7%) vs baseline: ~same Memory: ✅ 66.070MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.7% ✅ span-code-originTime: ✅ 25.354ms (SLO: <28.200ms 📉 -10.1%) vs baseline: -0.2% Memory: ✅ 67.264MB (SLO: <69.500MB -3.2%) vs baseline: +5.0% ✅ tracerTime: ✅ 20.424ms (SLO: <21.750ms -6.1%) vs baseline: -0.2% Memory: ✅ 66.179MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.646ms (SLO: <23.500ms -3.6%) vs baseline: -0.2% Memory: ✅ 67.886MB (SLO: <68.000MB 🟡 -0.2%) vs baseline: +5.1% ✅ tracer-dont-create-db-spansTime: ✅ 19.253ms (SLO: <21.500ms 📉 -10.5%) vs baseline: -0.3% Memory: ✅ 66.162MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.670ms (SLO: <17.500ms -4.7%) vs baseline: +0.4% Memory: ✅ 66.119MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.399ms (SLO: <21.750ms -6.2%) vs baseline: ~same Memory: ✅ 67.651MB (SLO: <72.500MB -6.7%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.427ms (SLO: <19.650ms -6.2%) vs baseline: -0.5% Memory: ✅ 66.146MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.742ms (SLO: <20.100ms -6.8%) vs baseline: -0.2% Memory: ✅ 66.118MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.133ms (SLO: <21.500ms -6.4%) vs baseline: -0.2% Memory: ✅ 66.159MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 20.223ms (SLO: <22.000ms -8.1%) vs baseline: -0.1% Memory: ✅ 66.076MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.7% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.031ms (SLO: <19.850ms -9.2%) vs baseline: -0.3% Memory: ✅ 66.031MB (SLO: <66.500MB 🟡 -0.7%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.017ms (SLO: <19.400ms -7.1%) vs baseline: ~same Memory: ✅ 66.187MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.139ms (SLO: <19.450ms -6.7%) vs baseline: +0.5% Memory: ✅ 65.759MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +4.7% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.076ms (SLO: <2.300ms -9.8%) vs baseline: ~same Memory: ✅ 52.691MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 2.074ms (SLO: <2.250ms -7.8%) vs baseline: -0.3% Memory: ✅ 52.632MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.087ms (SLO: <2.300ms -9.3%) vs baseline: +0.7% Memory: ✅ 52.671MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.0% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.593ms (SLO: <4.750ms -3.3%) vs baseline: -0.3% Memory: ✅ 62.282MB (SLO: <65.000MB -4.2%) vs baseline: +4.6% ✅ appsec-postTime: ✅ 6.618ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: +0.2% Memory: ✅ 62.104MB (SLO: <65.000MB -4.5%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.589ms (SLO: <4.750ms -3.4%) vs baseline: -0.5% Memory: ✅ 62.418MB (SLO: <65.000MB -4.0%) vs baseline: +5.0% ✅ debuggerTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: ~same Memory: ✅ 45.290MB (SLO: <47.000MB -3.6%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.881ms (SLO: <2.000ms -5.9%) vs baseline: +1.1% Memory: ✅ 42.391MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +5.0% ✅ profilerTime: ✅ 1.909ms (SLO: <2.100ms -9.1%) vs baseline: -0.2% Memory: ✅ 46.497MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: +0.2% Memory: ✅ 52.786MB (SLO: <53.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.356ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 52.740MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.346ms (SLO: <3.650ms -8.3%) vs baseline: -0.2% Memory: ✅ 54.311MB (SLO: <60.000MB -9.5%) vs baseline: +4.9% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.952ms (SLO: <4.200ms -5.9%) vs baseline: +0.1% Memory: ✅ 62.364MB (SLO: <66.000MB -5.5%) vs baseline: +4.9% ✅ iast-enabledTime: ✅ 2.442ms (SLO: <2.800ms 📉 -12.8%) vs baseline: +0.6% Memory: ✅ 59.159MB (SLO: <60.000MB 🟡 -1.4%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 2.058ms (SLO: <2.250ms -8.5%) vs baseline: ~same Memory: ✅ 52.632MB (SLO: <54.500MB -3.4%) vs baseline: +4.7% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 309.426ms (SLO: <320.950ms -3.6%) vs baseline: +0.2% Memory: ✅ 32.834MB (SLO: <34.500MB -4.8%) vs baseline: +4.9% ✅ deep-profiledTime: ✅ 328.418ms (SLO: <359.150ms -8.6%) vs baseline: +0.2% Memory: ✅ 38.381MB (SLO: <39.000MB 🟡 -1.6%) vs baseline: +5.1% ✅ mediumTime: ✅ 7.019ms (SLO: <7.400ms -5.1%) vs baseline: +0.3% Memory: ✅ 32.047MB (SLO: <34.000MB -5.7%) vs baseline: +4.7% ✅ shallowTime: ✅ 0.942ms (SLO: <1.050ms 📉 -10.3%) vs baseline: +0.1% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +5.0% 🟡 span - 26/26✅ add-eventTime: ✅ 19.826ms (SLO: <22.500ms 📉 -11.9%) vs baseline: ~same Memory: ✅ 48.504MB (SLO: <53.000MB -8.5%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 90.184ms (SLO: <93.500ms -3.5%) vs baseline: ~same Memory: ✅ 735.728MB (SLO: <961.000MB 📉 -23.4%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 147.866ms (SLO: <155.000ms -4.6%) vs baseline: +1.0% Memory: ✅ 735.980MB (SLO: <962.500MB 📉 -23.5%) vs baseline: +4.9% ✅ get-contextTime: ✅ 18.201ms (SLO: <20.500ms 📉 -11.2%) vs baseline: -0.5% Memory: ✅ 47.410MB (SLO: <53.000MB 📉 -10.5%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 18.531ms (SLO: <20.500ms -9.6%) vs baseline: -0.3% Memory: ✅ 47.366MB (SLO: <53.000MB 📉 -10.6%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 38.238ms (SLO: <40.000ms -4.4%) vs baseline: +2.7% Memory: ✅ 41.806MB (SLO: <53.000MB 📉 -21.1%) vs baseline: +4.9% ✅ set-statusTime: ✅ 20.043ms (SLO: <22.000ms -8.9%) vs baseline: -0.4% Memory: ✅ 47.425MB (SLO: <53.000MB 📉 -10.5%) vs baseline: +5.0% ✅ startTime: ✅ 18.584ms (SLO: <20.500ms -9.3%) vs baseline: +2.8% Memory: ✅ 47.389MB (SLO: <53.000MB 📉 -10.6%) vs baseline: +5.0% ✅ start-finishTime: ✅ 51.553ms (SLO: <52.500ms 🟡 -1.8%) vs baseline: +2.0% Memory: ✅ 32.047MB (SLO: <34.000MB -5.7%) vs baseline: +5.1% ✅ start-finish-telemetryTime: ✅ 52.421ms (SLO: <54.500ms -3.8%) vs baseline: +0.8% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.2% ✅ start-finish-traceid128Time: ✅ 53.758ms (SLO: <57.000ms -5.7%) vs baseline: -0.2% Memory: ✅ 32.027MB (SLO: <34.000MB -5.8%) vs baseline: +4.8% ✅ start-traceid128Time: ✅ 18.954ms (SLO: <22.500ms 📉 -15.8%) vs baseline: +2.3% Memory: ✅ 47.430MB (SLO: <53.000MB 📉 -10.5%) vs baseline: +4.9% ✅ update-nameTime: ✅ 18.854ms (SLO: <22.000ms 📉 -14.3%) vs baseline: +0.9% Memory: ✅ 48.054MB (SLO: <53.000MB -9.3%) vs baseline: +4.9%
|
Description
Testing
Risks
Additional Notes