-
Notifications
You must be signed in to change notification settings - Fork 467
chore(profiling): fix flaky test: 'test_upload_resets_profile' #15178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(profiling): fix flaky test: 'test_upload_resets_profile' #15178
Conversation
|
|
80ead8a to
e91f6b3
Compare
297db08 to
006d5a3
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 239 ± 3 ms. The average import time from base is: 245 ± 5 ms. The import time difference between this PR and base is: -5.7 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
KowalskiThomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix makes sense to me, I hope it doesn't just make it less flaky since we're just waiting an arbitrary amount of time 🤞
Performance SLOsComparing candidate vlad/lockprof-flaky-test_upload_resets_profile (8ae5e07) with baseline main (1717b70) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.378µs (SLO: <10.000µs 📉 -56.2%) vs baseline: +2.9% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.088µs (SLO: <10.000µs 📉 -89.1%) vs baseline: -0.2% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 6.385µs (SLO: <10.000µs 📉 -36.2%) vs baseline: +3.4% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 2.290µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.1% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 4.003µs (SLO: <10.000µs 📉 -60.0%) vs baseline: 📈 +14.1% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.575µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.8% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ ospathsplit_aspectTime: ✅ 4.784µs (SLO: <10.000µs 📉 -52.2%) vs baseline: -1.3% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 1.588µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -1.0% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.739µs (SLO: <10.000µs 📉 -62.6%) vs baseline: +2.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.702µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +1.1% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.560µs (SLO: <10.000µs 📉 -54.4%) vs baseline: +0.6% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.371µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -0.6% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.532ms (SLO: <22.300ms -7.9%) vs baseline: +0.3% Memory: ✅ 66.158MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.338ms (SLO: <1.450ms -7.8%) vs baseline: +0.2% Memory: ✅ 64.276MB (SLO: <67.000MB -4.1%) vs baseline: +4.9% ✅ iastTime: ✅ 20.414ms (SLO: <22.250ms -8.3%) vs baseline: -0.6% Memory: ✅ 66.247MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.2% ✅ profilerTime: ✅ 15.569ms (SLO: <16.550ms -5.9%) vs baseline: +0.1% Memory: ✅ 53.937MB (SLO: <54.500MB 🟡 -1.0%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 20.519ms (SLO: <21.750ms -5.7%) vs baseline: ~same Memory: ✅ 66.198MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.1% ✅ span-code-originTime: ✅ 25.033ms (SLO: <28.200ms 📉 -11.2%) vs baseline: -1.7% Memory: ✅ 67.345MB (SLO: <69.500MB -3.1%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.514ms (SLO: <21.750ms -5.7%) vs baseline: +0.4% Memory: ✅ 66.191MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.2% ✅ tracer-and-profilerTime: ✅ 22.725ms (SLO: <23.500ms -3.3%) vs baseline: -0.1% Memory: ✅ 68.016MB (SLO: <68.000MB ~same) vs baseline: +5.3% ✅ tracer-dont-create-db-spansTime: ✅ 19.301ms (SLO: <21.500ms 📉 -10.2%) vs baseline: -0.1% Memory: ✅ 66.129MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.613ms (SLO: <17.500ms -5.1%) vs baseline: -0.5% Memory: ✅ 66.050MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.477ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 67.790MB (SLO: <72.500MB -6.5%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.546ms (SLO: <19.650ms -5.6%) vs baseline: +0.4% Memory: ✅ 66.198MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.800ms (SLO: <20.100ms -6.5%) vs baseline: +0.1% Memory: ✅ 65.903MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.5% ✅ tracer-no-middlewareTime: ✅ 20.135ms (SLO: <21.500ms -6.3%) vs baseline: -0.3% Memory: ✅ 66.267MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.3% ✅ tracer-no-templatesTime: ✅ 20.291ms (SLO: <22.000ms -7.8%) vs baseline: -0.2% Memory: ✅ 66.119MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.017ms (SLO: <19.850ms -9.2%) vs baseline: ~same Memory: ✅ 66.052MB (SLO: <66.500MB 🟡 -0.7%) vs baseline: +4.6% ✅ errortracking-enabled-userTime: ✅ 18.087ms (SLO: <19.400ms -6.8%) vs baseline: ~same Memory: ✅ 66.102MB (SLO: <66.500MB 🟡 -0.6%) vs baseline: +4.7% ✅ tracer-enabledTime: ✅ 18.073ms (SLO: <19.450ms -7.1%) vs baseline: ~same Memory: ✅ 65.937MB (SLO: <66.500MB 🟡 -0.8%) vs baseline: +5.1% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.091ms (SLO: <2.300ms -9.1%) vs baseline: +1.6% Memory: ✅ 52.652MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 2.096ms (SLO: <2.250ms -6.8%) vs baseline: +1.6% Memory: ✅ 52.632MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.082ms (SLO: <2.300ms -9.5%) vs baseline: +0.8% Memory: ✅ 52.573MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: ~same Memory: ✅ 62.338MB (SLO: <65.000MB -4.1%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.621ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: -0.5% Memory: ✅ 62.365MB (SLO: <65.000MB -4.1%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.591ms (SLO: <4.750ms -3.4%) vs baseline: +0.2% Memory: ✅ 62.284MB (SLO: <65.000MB -4.2%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.855ms (SLO: <2.000ms -7.3%) vs baseline: -0.1% Memory: ✅ 45.177MB (SLO: <47.000MB -3.9%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.855ms (SLO: <2.000ms -7.3%) vs baseline: -0.3% Memory: ✅ 42.141MB (SLO: <49.000MB 📉 -14.0%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.914ms (SLO: <2.100ms -8.9%) vs baseline: +0.2% Memory: ✅ 46.717MB (SLO: <47.000MB 🟡 -0.6%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 3.365ms (SLO: <3.650ms -7.8%) vs baseline: +0.3% Memory: ✅ 52.716MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.2% ✅ tracerTime: ✅ 3.350ms (SLO: <3.650ms -8.2%) vs baseline: ~same Memory: ✅ 52.611MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.349ms (SLO: <3.650ms -8.3%) vs baseline: +0.3% Memory: ✅ 54.075MB (SLO: <60.000MB -9.9%) vs baseline: +4.8%
|
006d5a3 to
8ae5e07
Compare
Description
This PR fixes a race condition in
test_upload_resets_profilecausing intermittent failures on macOS. The test verifies thatddup.upload()resets the profile, but async I/O operations were completing at unpredictable times.Problem: Test expects empty profile after second upload, but occasionally still finds samples due to:
Changes
Added synchronization points to ensure operations complete before assertions:
Testing