-
Notifications
You must be signed in to change notification settings - Fork 467
chore: improve scripts/run-tests --venv handling #15188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 249 ± 5 ms. The average import time from base is: 244 ± 4 ms. The import time difference between this PR and base is: 5.3 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate brettlangdon/improve.run-tests.venv (8580729) with baseline main (1717b70) 📈 Performance Regressions (1 suite)📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.045µs (SLO: <20.000µs 📉 -84.8%) vs baseline: +3.9% Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +4.8% ✅ 1-count-metrics-100-timesTime: ✅ 202.080µs (SLO: <220.000µs -8.1%) vs baseline: +1.0% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.292µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -0.2% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.5% ✅ 1-distribution-metrics-100-timesTime: ✅ 211.744µs (SLO: <220.000µs -3.8%) vs baseline: -0.7% Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.8% ✅ 1-gauge-metric-1-timesTime: ✅ 2.213µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +1.6% Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.250µs (SLO: <150.000µs -8.5%) vs baseline: +0.7% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +5.1% ✅ 1-rate-metric-1-timesTime: ✅ 3.452µs (SLO: <20.000µs 📉 -82.7%) vs baseline: 📈 +11.7% Memory: ✅ 31.929MB (SLO: <34.000MB -6.1%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 213.421µs (SLO: <250.000µs 📉 -14.6%) vs baseline: +1.2% Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.035ms (SLO: <22.000ms -8.9%) vs baseline: +0.3% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.213ms (SLO: <2.300ms -3.8%) vs baseline: ~same Memory: ✅ 31.929MB (SLO: <34.000MB -6.1%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.420ms (SLO: <1.550ms -8.4%) vs baseline: +1.7% Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.8% ✅ 100-rate-metrics-100-timesTime: ✅ 2.191ms (SLO: <2.550ms 📉 -14.1%) vs baseline: +0.3% Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +5.1% ✅ flush-1-metricTime: ✅ 4.417µs (SLO: <20.000µs 📉 -77.9%) vs baseline: +0.1% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.5% ✅ flush-100-metricsTime: ✅ 176.513µs (SLO: <250.000µs 📉 -29.4%) vs baseline: +0.2% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.141ms (SLO: <2.500ms 📉 -14.4%) vs baseline: -0.3% Memory: ✅ 32.716MB (SLO: <34.500MB -5.2%) vs baseline: +4.9% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.504ms (SLO: <22.300ms -8.1%) vs baseline: ~same Memory: ✅ 66.218MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ exception-replay-enabledTime: ✅ 1.347ms (SLO: <1.450ms -7.1%) vs baseline: +0.5% Memory: ✅ 64.262MB (SLO: <67.000MB -4.1%) vs baseline: +5.0% ✅ iastTime: ✅ 20.421ms (SLO: <22.250ms -8.2%) vs baseline: -0.5% Memory: ✅ 66.237MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.620ms (SLO: <16.550ms -5.6%) vs baseline: +0.5% Memory: ✅ 53.977MB (SLO: <54.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 20.519ms (SLO: <21.750ms -5.7%) vs baseline: ~same Memory: ✅ 66.208MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 25.465ms (SLO: <28.200ms -9.7%) vs baseline: -0.3% Memory: ✅ 67.010MB (SLO: <69.500MB -3.6%) vs baseline: +4.4% ✅ tracerTime: ✅ 20.492ms (SLO: <21.750ms -5.8%) vs baseline: ~same Memory: ✅ 66.143MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-and-profilerTime: ✅ 22.678ms (SLO: <23.500ms -3.5%) vs baseline: +0.1% Memory: ✅ 68.006MB (SLO: <68.000MB ~same) vs baseline: +5.1% ✅ tracer-dont-create-db-spansTime: ✅ 19.326ms (SLO: <21.500ms 📉 -10.1%) vs baseline: -0.1% Memory: ✅ 66.186MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.578ms (SLO: <17.500ms -5.3%) vs baseline: -0.4% Memory: ✅ 65.981MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.395ms (SLO: <21.750ms -6.2%) vs baseline: ~same Memory: ✅ 67.751MB (SLO: <72.500MB -6.6%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.465ms (SLO: <19.650ms -6.0%) vs baseline: -0.5% Memory: ✅ 66.139MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ tracer-no-databasesTime: ✅ 18.793ms (SLO: <20.100ms -6.5%) vs baseline: +0.4% Memory: ✅ 65.886MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.180ms (SLO: <21.500ms -6.1%) vs baseline: ~same Memory: ✅ 66.073MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.334ms (SLO: <22.000ms -7.6%) vs baseline: +0.3% Memory: ✅ 66.080MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.018ms (SLO: <19.850ms -9.2%) vs baseline: +0.2% Memory: ✅ 66.218MB (SLO: <66.500MB 🟡 -0.4%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.076ms (SLO: <19.400ms -6.8%) vs baseline: +0.2% Memory: ✅ 66.159MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.134ms (SLO: <19.450ms -6.8%) vs baseline: -0.2% Memory: ✅ 65.864MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +4.7% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.591ms (SLO: <4.750ms -3.3%) vs baseline: -0.4% Memory: ✅ 62.306MB (SLO: <65.000MB -4.1%) vs baseline: +4.7% ✅ appsec-postTime: ✅ 6.618ms (SLO: <6.750ms 🟡 -2.0%) vs baseline: -0.4% Memory: ✅ 62.343MB (SLO: <65.000MB -4.1%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.597ms (SLO: <4.750ms -3.2%) vs baseline: ~same Memory: ✅ 62.360MB (SLO: <65.000MB -4.1%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.868ms (SLO: <2.000ms -6.6%) vs baseline: +0.2% Memory: ✅ 45.369MB (SLO: <47.000MB -3.5%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: -0.8% Memory: ✅ 42.172MB (SLO: <49.000MB 📉 -13.9%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.919ms (SLO: <2.100ms -8.6%) vs baseline: +0.2% Memory: ✅ 46.714MB (SLO: <47.000MB 🟡 -0.6%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.358ms (SLO: <3.650ms -8.0%) vs baseline: -0.3% Memory: ✅ 52.573MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracerTime: ✅ 3.355ms (SLO: <3.650ms -8.1%) vs baseline: -0.3% Memory: ✅ 52.658MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.348ms (SLO: <3.650ms -8.3%) vs baseline: ~same Memory: ✅ 53.983MB (SLO: <60.000MB 📉 -10.0%) vs baseline: +4.6% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.981ms (SLO: <4.200ms -5.2%) vs baseline: +0.2% Memory: ✅ 62.325MB (SLO: <66.000MB -5.6%) vs baseline: +4.7% ✅ iast-enabledTime: ✅ 2.445ms (SLO: <2.800ms 📉 -12.7%) vs baseline: -0.4% Memory: ✅ 58.805MB (SLO: <60.000MB 🟡 -2.0%) vs baseline: +4.6% ✅ tracer-enabledTime: ✅ 2.057ms (SLO: <2.250ms -8.6%) vs baseline: -0.6% Memory: ✅ 52.691MB (SLO: <54.500MB -3.3%) vs baseline: +4.9%
|
Description
If you run
scripts/run-tests --venv <hash>it might still expect you to provide changed files or look at git diff for changed files to determine which venvs are possible to run.With this change, if
--venv <hash>is provided we run those hashes directly now instead.Testing
Risks
Additional Notes