Skip to content

Sped up DataTable loading when heavy sorting is involved #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Brilliand
Copy link

Had some trouble with "api.rows().invalidate()" causing
an exponentially increasing slowdown when loading a
heavily reordered table. Changed _fnOrderColumns to
call that function (and a few other "refresh all" functions)
only once.

Had some trouble with "api.rows().invalidate()" causing
an exponentially increasing slowdown when loading a
heavily reordered table.  Changed _fnOrderColumns to
call that function (and a few other "refresh all" functions)
only once.
@DataTables
Copy link
Collaborator

Thanks very much for this. I haven't looked through the change yet (there is quite a lot of additional code it looks like), but just to say that the error with DataTables invalidation function should be fixed in the current nightly ( https://github.com/DataTables/DataTables/tree/master/media/js ) if you fancy giving it a go.

@Brilliand
Copy link
Author

The extra code is mostly a copy-paste of fnColReorder - it's just different enough that there was no obvious way to keep that one function suitable for both purposes. The code duplication could probably be reduced quite a bit, though.

@719media
Copy link
Contributor

719media commented May 6, 2016

I ran into this issue, and it is really bad lockup.

I created an updated/easier to merge #57, which I'm sure can be improved upon by someone who is more familiar with the code.

@Brilliand Brilliand closed this May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants