Redraw bug fix+get current order api #2
Conversation
|
I think the new API method you suggest is a nice idea and that should certainly be included. Thanks. For the destroy issue, I think a better solution might be to listen for the DataTables' destroy event and detach itself from all callbacks at that point. This is how TableTools does it: https://github.com/DataTables/TableTools/blob/master/media/js/TableTools.js#L676 . Does that sound like it would cover the issue you were seeing? |
|
That sounds better. I first tried looking for an easy way to remove the callbacks, but DataTables' API and the document were puzzling me. It seems TableTools isn't really removing any callbacks from DataTables side. I'll take a more thorough look and fix my commits. |
- ColReorder's redraw callback was getting called sometimes after it has been destroyed, and this caused an error. For instance, as DataTable gets destroyed, it first calls all the destroy callbacks, then tries to restore column visibility, but at that point, ColReorder's redraw callback gets triggered.
|
Yeah the API documentation is very lacking in that area... :-( TableTools doesn't really listen for callbacks from DataTables - just its own events, so it is slightly different. There isn't actually a |
- Without such API, the fnReorderCallback is not so useful. Now, we can access the new column order array within the callback as follows: this.fnGetCurrentOrder()
|
The new way of removing callback works fine as my previous change. You can refactor my fix when you add a |
|
Agreed. Not a very desirable set of circumstances - but that's what happens with legacy code! Merging in and noting for future enhancement. Thanks for the contribution! |
Redraw bug fix+get current order api
This is a bug fix and an API proposal.