Replacing 'jQuery' variable name with '$' sign #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in the ColReorder plugin, there were calls to jQuery.proxy() using the jQuery global namespace. While this might not be an issue while loading the libraries externally, but if your project has a RequireJS AMD setup then you would led to an error saying jQuery is not defined. In order to fix this, we could use a $ sign instead of the jQuery namespace while calling the $.proxy API. This commit would address this issue.
DataTables
pushed a commit
that referenced
this pull request
Jan 11, 2013
Replacing 'jQuery' variable name with '$' sign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the ColReorder plugin, there were calls to jQuery.proxy()
using the jQuery global namespace. While this
might not be an issue while loading the libraries externally, but if
your project has a RequireJS AMD setup then you would led to an error
saying jQuery is not defined. In order to fix this, we could use a $
sign instead of the jQuery namespace while calling the $.proxy API. This
commit would address this issue.