Rebase with swift 6.1.1 release #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find configuration based on CWD when formatting from stdin
fix readme typo
As trivial as this is, this change is to prevent a conflict with running the plugin with the `--configuration` parameter which is recognised and parsed by the Swift Package Manager and expects to be either `debug` or `release`. The replacement of `--swift-format-configuration` is verbose, but other choices looked too ambiguous or confusing whereas this is at least clear as to what the parameter is doing.
…ation-argument Renamed plugin configuration parameter
…ersion-to-510.1.0 Update README to specify version 510.1.0 for building from source
Fix comment for multiElementCollectionTrailingCommas
Fix some typos
Pretty-print `@_originallyDefinedIn` with the correct spacing.
…arguments Fix @_originallyDefinedIn argument spacing
With attribute such as `@_documentation(visibility: private)`, swift-format incorrectly prints no spacing between `visibility` and `private`.
…ty-printing Fix incorrect spacing when pretty-printing @_documentation
Fix link to Configuration.md
Update RuleDocumentation.md
You wouldn't normally allow a line break just before the comma in a parameter list, but if the preceding line is an #endif, we have to include the break or we'll generate invalid code.
Remove check for prioritizeKeepingFunctionOutputTogether on enum decl.
…ng-endif Make sure there is a break after an #endif.
Merge adjacent .line and .docLine comments into a single element.
swift-format#883 fixed outputting incorrect line numbers, but introduced a performance regression. swift-format#901 improved this back to around the original, but had to be reverted as it introduced a an issue due to counting codepoints rather than characters. Introduce a similar optimization again, but only for the first portion of the string (prior to the last newline). Fixes swift-format#894 again.
Optimize pretty printing performance
* `UnicodeScalar(_:)` on arbitrary UTF8 code point was wrong. It only works correctly if the code point is < 0x80 * `UnicodeScalar.Properties.isWhitespace` is slow. Profiling 'lint' shows it's taking 13.6 of the entire time * Whitespaces in Unicode "Basic Latin" block are well defined, there's no need to consult `UnicodeScalar.Properties`
[Perf][WhitespaceLinter] Use hand crafted "is whitespace" function
… '-' for stdin in the future
Gradually deprecate running swift-format without input paths; require '-' for stdin in the future
Documented missing config values in `Configuration.md`. Added the same description as inside inline docs. Documented values: * `fileScopedDeclarationPrivacy` * `indentSwitchCaseLabels` * `noAssignmentInExpressions` * `reflowMultilineStringLiterals`
Document missing configuration
Merge `main` into `release/6.1`
Looks like GitHub updated Visual Studio on their Windows runners and the new SDK causes compilation issues. Run in a Docker container so we fully control the version of Visual Studio installed.
[6.1] Run Windows tests inside a Docker container
This will make swift-format more tolerant with regard to which swift-argument-parser version it needs, resulting in fewer version conflicts for packages that depend on swift-format.
Signed-off-by: Deepak Raj H R <[email protected]>
Signed-off-by: Deepak Raj H R <[email protected]>
Signed-off-by: Deepak Raj H R <[email protected]>
Signed-off-by: Tushar Sadhwani <[email protected]>
…EASE Signed-off-by: Srijan Saurav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.