Skip to content

Stop using runtime C++ exceptions #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Stop using runtime C++ exceptions #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
411949b
Stop using runtime C++ exceptions
maelhos Jan 2, 2024
6b8a8f6
Merge remote-tracking branch 'upstream/master'
maelhos Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/cpp/templates/lr.template.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ class {{{PARSER_CLASS_NAME}}} {
if (token->type == TokenType::__EOF && !tokenizer.hasMoreTokens()) {
std::string errMsg = "Unexpected end of input.\n";
std::cerr << errMsg;
throw std::runtime_error(errMsg.c_str());
std::exit(EXIT_FAILURE);
}
tokenizer.throwUnexpectedToken(token->value, token->startLine,
token->startColumn);
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/cpp/templates/tokenizer.template.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ class Tokenizer {
<< ":" << column << "\n\n";

std::cerr << errMsg.str();
throw new std::runtime_error(errMsg.str().c_str());
std::exit(1);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be EXIT_FAILURE as well?

}

/**
Expand Down