Fix HttpLayerRouter
with RpcServer
example
#5625
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
By the definition of
RpcServer.layerHttpRouter
we need to explicitly provideprotocol
parameters or the code will treat route as Websocket and will register it withGET
method:https://github.com/Effect-TS/effect/blob/main/packages/rpc/src/RpcServer.ts#L758-L760
https://github.com/Effect-TS/effect/blob/main/packages/rpc/src/RpcServer.ts#L881
Related