Skip to content

Conversation

Ty3uK
Copy link

@Ty3uK Ty3uK commented Oct 8, 2025

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

By the definition of RpcServer.layerHttpRouter we need to explicitly provide protocol parameters or the code will treat route as Websocket and will register it with GET method:

https://github.com/Effect-TS/effect/blob/main/packages/rpc/src/RpcServer.ts#L758-L760

https://github.com/Effect-TS/effect/blob/main/packages/rpc/src/RpcServer.ts#L881

Related

  • Related Issue #
  • Closes #

@Ty3uK Ty3uK requested a review from tim-smart as a code owner October 8, 2025 07:57
@github-project-automation github-project-automation bot moved this to Discussion Ongoing in PR Backlog Oct 8, 2025
Copy link

changeset-bot bot commented Oct 8, 2025

⚠️ No Changeset found

Latest commit: 213d3d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Discussion Ongoing

Development

Successfully merging this pull request may close these issues.

1 participant