Skip to content

Conversation

@funwaa
Copy link
Contributor

@funwaa funwaa commented Oct 27, 2021

Adding 8-digit HEX string representation to fix issue #119

Adding 8-digit HEX string representation to fix issue FireDiscordBot#119
@GamingGeek GamingGeek linked an issue Oct 27, 2021 that may be closed by this pull request
@GamingGeek GamingGeek removed a link to an issue Oct 27, 2021
@GamingGeek
Copy link
Member

Thanks for the PR! After taking a more in-depth look at the change (a.k.a more than 2 seconds) it does not seem that this change is what Arthurism wanted in their issue but it's a good addition nonetheless.

@GamingGeek GamingGeek merged commit cc70b4f into FireDiscordBot:master Oct 27, 2021
@funwaa
Copy link
Contributor Author

funwaa commented Oct 27, 2021

Thanks for the PR! After taking a more in-depth look at the change (a.k.a more than 2 seconds) it does not seem that this change is what Arthurism wanted in their issue but it's a good addition nonetheless.

Hm, I'm not quite sure what they meant with their issue. Do you understand and can you explain it better?

@GamingGeek
Copy link
Member

Thanks for the PR! After taking a more in-depth look at the change (a.k.a more than 2 seconds) it does not seem that this change is what Arthurism wanted in their issue but it's a good addition nonetheless.

Hm, I'm not quite sure what they meant with their issue. Do you understand and can you explain it better?

HEX8 is just HEX with alpha. Decimal is the color represented as a numerical value. I've implemented it locally which you can see below
image

@funwaa
Copy link
Contributor Author

funwaa commented Oct 27, 2021

Thanks for the PR! After taking a more in-depth look at the change (a.k.a more than 2 seconds) it does not seem that this change is what Arthurism wanted in their issue but it's a good addition nonetheless.

Hm, I'm not quite sure what they meant with their issue. Do you understand and can you explain it better?

HEX8 is just HEX with alpha. Decimal is the color represented as a numerical value. I've implemented it locally which you can see below image

Oh I see. Using ${parseInt(color.toHex(), 16)} would've worked aswell, right?

@GamingGeek
Copy link
Member

GamingGeek commented Oct 27, 2021

Oh I see. Using ${parseInt(color.toHex(), 16)} would've worked aswell, right?

Indeed it would, didn't think of using that 😂

That's probably a better method than what I've done so I'll change it to that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants