Change order of $factories #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I'll test. |
|
@B3njamin could you rebase your branch against the master to avoid these extra commits? Thanks |
whatyoubendoing
force-pushed
the
master
branch
from
e13ea11 to
3348ee5
Compare
|
Sure - done :) |
|
@miniche could you test that? |
- Allows users to use the service container across other factories, for example in the session storage factory
whatyoubendoing
force-pushed
the
master
branch
from
3348ee5 to
60aeedc
Compare
alquerci
reviewed
Jul 21, 2018
|
|
||
| // available list of factories | ||
| $factories = array('view_cache_manager', 'logger', 'i18n', 'controller', 'request', 'response', 'routing', 'storage', 'user', 'view_cache', 'mailer', 'service_container'); | ||
| $factories = array('service_container', 'view_cache_manager', 'logger', 'i18n', 'controller', 'request', 'response', 'routing', 'storage', 'user', 'view_cache', 'mailer'); |
There was a problem hiding this comment.
The service container depends on user and routing (e.g; sfContext::getServiceContainer()).
For example try to get a service that depend on user inside the constructor of the response class.
You will caught that the sfContext::getInstance()->getUser() return null.
Another topic but it would be good to provide at least i18n and mailer as service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example in the session storage factory