dired-open-xdg: file path could contain quotes. use call-process.
#225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
dired-open-xdg, the shell command is constructed usingconcatto be run bycall-process-shell-command, and file path as an argument is surrounded by single quotes'to prevent most special characters being parsed as such except single quote itself.Thus, if the
filecontains single quotes anywhere in the path,dired-open-xdgwould fail to open it as the shell would not consider the path as a whole word.Using
call-processwould pass ARGS, in this case the file path, straight to the program as a whole, eliminating the issue of quotes as well as other shell special characters.