⚡️ Speed up method TensorChunker._split_value
by 89% in PR #272 (14__robusttraining
)
#273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ This pull request contains optimizations for PR #272
If you approve this dependent PR, these changes will be merged into the original PR branch
14__robusttraining
.📄 89% (0.89x) speedup for
TensorChunker._split_value
insrc/ldp/nn/handlers/chunking.py
⏱️ Runtime :
2.60 milliseconds
→1.38 millisecond
(best of82
runs)📝 Explanation and details
To optimize the existing code for speed, we can make use of more efficient operations for tensor handling and avoid unnecessary list operations within the function. Here is the rewritten program.
Changes Made
torch.chunk
function to split the tensor and handle the resulting chunks as a tuple.dummy_chunk_flags
list with appropriate lengths to avoid list appends in a loop.These changes ensure that the operations, particularly list appending and tensor manipulations, are as efficient as possible.
✅ Correctness verification report:
🌀 Generated Regression Tests Details
To edit these changes
git checkout codeflash/optimize-pr272-2025-04-07T15.04.58
and push.