Don't merge yet -- Deprecate use of Pythia 6 #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusense
approved these changes
Sep 15, 2025
There was a problem hiding this comment.
These changes seem to be complete as far as I can tell. I would like to see at least one tagged release that still has pythia6 available but the default changed to pythia8 on, pythia6 off and the changes to the XML files to support that, before we rip pythia6 support completely out of the code base.
|
Sounds good, I'll hold off on merging and use a different PR for the "Pythia 8 is now default, Pythia 6 is still allowed" setup. |
sjgardiner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deprecates Pythia 6 and removes references to it from the GENIE code base. PR #430 should be combined with this one to configure Pythia 8 properly.