Skip to content

chore: change pre-commit hook for prettier #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Conversation

sevbch
Copy link
Collaborator

@sevbch sevbch commented Jun 24, 2025

Context

Prettier pre-commit hook is failing a bit randomly in our CI: see here where it wants to remove lines and here where it wants to add the very same lines.

What has been done

https://github.com/pre-commit/mirrors-prettier isn't maintained anymore and was archived in April 2024.

We are switching to https://github.com/rbubley/mirrors-prettier which is a maintained fork of the above. Hopefully it will fix the issue.

Also adding along the way some new standards hooks.

Validation

Can't really validate, just hoping we won't have that random thing again.

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.90%. Comparing base (95738b6) to head (c3f89cf).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1108   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files         144      144           
  Lines        6102     6102           
=======================================
  Hits         5608     5608           
  Misses        494      494           
Flag Coverage Δ
unittests 91.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sevbch sevbch force-pushed the severine/pre-commit-prettier branch from c8c4ae9 to 76bac52 Compare June 24, 2025 10:33
@sevbch sevbch force-pushed the severine/pre-commit-prettier branch from 76bac52 to c3f89cf Compare June 24, 2025 10:58
@sevbch sevbch marked this pull request as ready for review June 24, 2025 11:09
@sevbch sevbch requested a review from a team as a code owner June 24, 2025 11:09
@sevbch sevbch merged commit e1f78c7 into main Jun 24, 2025
29 checks passed
@sevbch sevbch deleted the severine/pre-commit-prettier branch June 24, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants