Skip to content

Conversation

@bernii
Copy link

@bernii bernii commented Apr 5, 2017

The plugin is generating a flat log line which is really hard to read as full stack trace in a single line is not really human readable.

This PR adds support for join_separator that allows the user to customize the character that is used when concatenating detected stack trace lines (for example join_separator "\n" can be used).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@bernii
Copy link
Author

bernii commented Apr 5, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@thomasschickinger
Copy link
Contributor

AFAICT your concern with the long log line is addressed by the pending PR
#10.

The fact that exceptions from text logs could end up on a single line was never intended. The mentioned PR makes sure that there is always a line separator in between. PTAL whether this addresses your requirements.

@bernii
Copy link
Author

bernii commented Apr 6, 2017

Yeah looks like #10 already solves it! I'm going to close this one then, thanks!

@bernii bernii closed this Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants