-
Couldn't load subscription status.
- Fork 69
Reconcile migration to v1 fluentd API and conform to latest code. #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All test pass, please merge this @qingling128 ! |
|
Dear @qingling128 and @igorpeshansky , I am beginning to worry about you guys. Is everything okay at Google Cloud? Yours with PRs ready to merge, |
|
I heard about the Google Cloud networking outage yesterday. Is everything okay? If the Google Cloud is holding you hostage please blink twice and drop your gpg public keys from the honeypot. We can get you out with the eSWAT team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that the current latest code does not support reloading. Therefore, when merging your code, please be mindful of this limitation and ensure that any necessary actions or configurations are taken into consideration to handle this situation appropriately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
Closes #77 |
- fixing missing code to make v1 API commit work with upstream changes - fixing functions for new parameter force_line_breaks - fixing rubocop errors and exanded lineLength to 100 chars - all tests pass on ruby 2.7.4 - this combines GoogleCloudPlatform#45 (resolves GoogleCloudPlatform#45) and reconciles it for the latest code changes in upstream Signed-off-by: Cryptophobia <[email protected]>
|
@lvelvis @nshelke777 , can you please review and merge in? I have rebased and fixed all rake tests that were failing. |
fix: reconcile upstream with v1 API PR
force_line_breaksSigned-off-by: Cryptophobia [email protected]