Skip to content

Conversation

@Cryptophobia
Copy link

@Cryptophobia Cryptophobia commented Nov 10, 2021

fix: reconcile upstream with v1 API PR

  • fixing missing code to make v1 API commit work with upstream changes
  • fixing functions for new parameter force_line_breaks
  • fixing rubocop errors and exanded lineLength to 100 chars
  • all tests pass on ruby 2.7.4
  • this combines Migrate to Fluentd v1 API #45 (resolves Migrate to Fluentd v1 API #45) and reconciles it for the latest code changes in upstream

Signed-off-by: Cryptophobia [email protected]

@google-cla
Copy link

google-cla bot commented Nov 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 10, 2021
@Cryptophobia
Copy link
Author

All test pass, please merge this @qingling128 !

@Cryptophobia
Copy link
Author

Dear @qingling128 and @igorpeshansky ,

I am beginning to worry about you guys. Is everything okay at Google Cloud?

Yours with PRs ready to merge,
@Cryptophobia

@Cryptophobia
Copy link
Author

I heard about the Google Cloud networking outage yesterday. Is everything okay?

If the Google Cloud is holding you hostage please blink twice and drop your gpg public keys from the honeypot. We can get you out with the eSWAT team.

Copy link

@lvelvis lvelvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that the current latest code does not support reloading. Therefore, when merging your code, please be mindful of this limitation and ensure that any necessary actions or configurations are taken into consideration to handle this situation appropriately.

Copy link

@nshelke777 nshelke777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Cryptophobia
Copy link
Author

Closes #77

  - fixing missing code to make v1 API commit work with upstream changes
  - fixing functions for new parameter force_line_breaks
  - fixing rubocop errors and exanded lineLength to 100 chars
  - all tests pass on ruby 2.7.4
  - this combines GoogleCloudPlatform#45 (resolves GoogleCloudPlatform#45) and reconciles it for the latest code changes in upstream

Signed-off-by: Cryptophobia <[email protected]>
@Cryptophobia
Copy link
Author

@lvelvis @nshelke777 , can you please review and merge in? I have rebased and fixed all rake tests that were failing.

$ rake test
...
Started
Finished in 3.308254697 seconds.
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
28 tests, 2537 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
8.46 tests/s, 766.87 assertions/s

@Cryptophobia
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants