Skip to content

fix: Update repository URL #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

fix: Update repository URL #4143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion recaptcha_enterprise/demosite/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
},
"repository": {
"type": "git",
"url": "https://github.com/googleapis/nodejs-recaptcha-enterprise.git"
"directory": "packages/google-cloud-recaptchaenterprise",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The directory path for the package within the monorepo appears to be incorrect. For a package named @google-cloud/recaptcha-enterprise, the directory in the google-cloud-node monorepo is expected to be packages/recaptcha-enterprise.

The current value packages/google-cloud-recaptchaenterprise seems to have a redundant google-cloud- prefix. An incorrect path here will break repository links on npmjs.com and for tools like npm repo.

        "directory": "packages/recaptcha-enterprise",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faube can you verify if this warning is valid?

Copy link
Contributor Author

@faube faube Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this is gemini hallucinating.
according to this page
https://docs.npmjs.com/cli/v11/configuring-npm/package-json#repository
"If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives:"

Since the full URL is
https://github.com/googleapis/google-cloud-node/tree/main/packages/google-cloud-recaptchaenterprise

the directory under the root directory is packages/google-cloud-recaptchaenterprise

In any case this has no runtime impact, it's essentially documentation.

"url": "https://github.com/googleapis/google-cloud-node.git"
},
"dependencies": {
"@google-cloud/recaptcha-enterprise": "^5.5.0",
Expand Down
Loading