ITP-2025-1|Elena Vasileia|Week 5|Module-Structuring-and-Testing-Data/Sprint-2 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redeclaration of 'str' variable in the 'capitalise' function.
Fixed a typo in comments line 23
Fixed variable scope issue by declaring decimalNumber before the function and logging the function's output.
Corrected the square function to accept a parameter and return its square. Tested it by loging the functions value in the console
Updated the multiply function to return the product instead of logging it, fixing the undefined result issue.
Corrected the sum function to return the sum of two parameters.
Updated getLastDigit function to accept a parameter and return the last digit of the provided number. Deleted the previous definition of num variable
Created a function to calculate bmi rounded up to one decimal
Implemented upperSnake function to convert string to upper snake case.
Implemented toPounds function to convert pence to pounds format.
Updated comments with answers for time formatting questions. I didn't use Python visualizer as it doesn't really help me.
I tried many methods, but this is sitting the best with my logic. As I am more comfortable atm to work with strings I only converted to numbers when I had to do comparisons, then gave the results to string again.
EL1VAS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I worked throughout all exersices adding comments as answers and explanations.
I was researching and learning simultaneously the unknown topics.
Found quite challenging and exciting the pounds and hours projects, good work making this an exersice, it really allowed me to deeply understand a lot of consepts .