Skip to content

Conversation

daeho-ro
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 14:20
@github-actions github-actions bot added the java Java use is a significant feature of the PR or issue label Oct 15, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the ltex-ls formula from Python 3.13 to Python 3.14 and pins the OpenJDK dependency to version 21 due to compatibility issues with newer versions (25+).

Key changes:

  • Updated Python dependency from [email protected] to [email protected]
  • Changed OpenJDK dependency from generic openjdk to pinned openjdk@21 with a comment explaining the version limitation
  • Updated all references to use the new Python and Java versions throughout the installation process

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 15, 2025
@BrewTestBot BrewTestBot enabled auto-merge October 15, 2025 16:23
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit bc5287a Oct 15, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the ltex-ls-python branch October 15, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. java Java use is a significant feature of the PR or issue python-3.14-migration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants