Remove deployAtEnd because it disables publishing

[ddelong]

Problem

-DdeployAtEnd=true actually prevents packages from being correctly published to Nexus.

Solution

Remove it. This goes back to a previously known build configuration, but retains the build exclusion from the original commit: #39

Testing

Verified new versions of the package are available in Nexus.

[bbeaudreault]

I don't think that's true actually. We use deployAtEnd in the hbase build, and that is publishing artifacts. I do think it's preferable to use deployAtEnd in general for multi-module builds. The reason is that it's less likely for a build to fail partway through, having uploaded some artifacts and then not uploading the rest. This can be important because of the inter-dependency of the modules. That said, it's not a strong requirement so if this is one way to fix the build then that's fine.

[ddelong]

I'm unsure what the conflict here is. I can iterate, but once I removed this piece, the libraries were being published again. I don't think what I've written is false. Where it is, this addition is preventing publication.

[bbeaudreault]

My comment was not meant to block your merge, per the last sentence. I do think it's false to say that deployAtEnd on its own prevents packages from being published. That's all I wanted to point out, so that we don't have an incorrect understanding of the situation. It's possible that it's a problem deployAtEnd combined with -pl, or something else.

[ddelong]

Great, I'll proceed. I tried moving the option around, but no joy. However, I did a little more research and this blog post looks like a likely reason this isn't working as expected: https://robinhowlett.com/blog/2019/05/15/solved-when-the-maven-deploy-plugin-silently-fails-to-deploy/