allow watch bookmarks in Reflector watches by default #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euberseder-hubspot
force-pushed
the
watch-bookmarks
branch
from
f76ec54 to
c220520
Compare
euberseder-hubspot
changed the title
nhirakawa
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables watch bookmarks by default in the reflector, with an environment option to disable and revert to the previous behavior.
There is a rather unfortunate difference between specifically enabling watch bookmarks and not disabling watch bookmarks as can be seen here: https://github.com/HubSpot/kubernetes-client/blob/6.13.4-hubspot/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/AbstractWatchManager.java#L136-L140
We do not want to receive watch bookmarks, as that will cause deserialization errors, but we do want the optimization provided by having the list resource version continuously updated. If nothing is set in the list options builder, we won't receive watch bookmarks, but they are enabled on watch requests and the resource version is updated before they are discarded.
Relates to https://git.hubteam.com/HubSpot/kube-operators/issues/9802