Skip to content

chore: update min supported python version to 3.11 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025

Conversation

abn
Copy link
Contributor

@abn abn commented Jun 20, 2025

ExceptionGroups is not available in Python version prior to 3.11. The project uses them in gateway service implementation. I have updated the minimum version and the lock file.

except* GatewayConnectionError as ge:
logger.error("GatewayConnectionError in group: %s", ge.exceptions)
raise ge.exceptions[0]
except* ValueError as ve:
logger.error("ValueErrors in group: %s", ve.exceptions)
raise ve.exceptions[0]
except* RuntimeError as re:
logger.error("RuntimeErrors in group: %s", re.exceptions)
raise re.exceptions[0]
except* BaseException as other: # catches every other sub-exception
logger.error("Other grouped errors: %s", other.exceptions)
raise other.exceptions[0]

@abn abn requested a review from crivetimihai as a code owner June 20, 2025 21:17
@abn abn force-pushed the fix/pyproject branch from f4da30d to 3d6a240 Compare June 20, 2025 21:18
Copy link
Member

@crivetimihai crivetimihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Will add tox to Actions.

@crivetimihai crivetimihai merged commit 934a292 into IBM:main Jun 21, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants