Merge code supporting 3D content in IIIF manifests into manifesto #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and adjusted tests accordingly
is*Transform attributes
as color-string npm package
with unit testing and documentation
the raw representation of intensity is supported.
…nifesto-3d into upstream_changes
Merge base manifesto upstream changes into manifesto-3d
had to manually include docs/.nojekyll and docs/index.html from manifest (2d) code
from the mainfesto/main side of the merge
the 'test' script still runs all tests including the 3d tests
there is no analogous file in that repository and not sure of this file is relevant anymore
in manifesto branch
At the Aug 26 2025 IIIF-Commons call it was agreed to retain the existing manifesto workflows.
IIIF-Commons/manifesto version of the release workflow
were appropriate to manifesto restored the manifesto scripts, retained the additional dependencies necessary to build the 3d code.
by the npm run prettify script Changes were generally replacing the "let" keyword with "const" keyword in those places where code analyis said that would be ok
a variable: from let size:string to const size:string
declaration of the size variable down to the point at which it can be declared and initialized in same statement
npm now gives "severe" security warnings about. All defined scripts still run
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will merge in the code developed to support the 3D extensions developed for Presentation 4 specification.
Discussed at the August 26 2025 call of the IIIF-Commons group, call minutes at Running Notes
Some notes on the state of this PR
-- All of the new code related to 3D content are included, as well as all of the tests.
-- As we discussed Aug 26, none of the additional workflow/actions developed in the 3D repository are included, in particular in this PR the documentation will continue to be generated manually.
-- The dependency on the module prettier-check has been removed, in response to "severe" security warnings now issued by npm upon install.
-- neither the docs nor the package-lock.json changes are included in the commit of this PR
-- the package naming, website, and GitHub repo are all set to the IIIF-Commons/manifesto values.
-- the version number is unchanged, is at 4.2.22, we agreed that if/when merge is is performed the version would be bumped to the next minor release