-
Couldn't load subscription status.
- Fork 20
775 account page notifications #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ekraffmiller
wants to merge
50
commits into
develop
Choose a base branch
from
775-account-page-notifications
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY26 Sprint 7
FY26 Sprint 7 (2025-09-24 - 2025-10-08)
FY26 Sprint 8
FY26 Sprint 8 (2025-10-08 - 2025-10-22)
FY26 Sprint 9
FY26 Sprint 9 (2025-10-22 - 2025-11-05)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA.Q3.2025.6
Account Page: Notifications
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements the Notifications tab of the Account Page.
Which issue(s) this PR closes:
Special notes for your reviewer:
This implementation uses a NotificationContext, and polling to get notification updates. I didn't add the icons next to the messages because I don't think they add much value, but if it's wanted I can add them.
Note that a
Suggestions on how to test this:
Do some actions in the SPA to trigger notifications. For example, create a new account, publish a dataset, upload a .csv file, or assign a role. The actions should update the Header to show the new unread notifications. Go to the Notifications tab to view them.
Note that a follow up PR will introduce paging, so that will handle the performance issues currently seen in JSF when there is a large amount of notifications.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes, rather than showing new notifications highlighted until the page is refreshed, as done in JSF, the SPA version of the page removes the highlight of the new notifications after a 2 second delay. After two seconds, the new notifications are marked as read, and the highlights are removed, and also the unread notifications badge is removed from the Header.
JSF Version
SPA Version
Is there a release notes update needed for this change?:
Additional documentation: