Skip to content

Conversation

@ChengShi-1
Copy link
Contributor

@ChengShi-1 ChengShi-1 commented Oct 15, 2025

What this PR does / why we need it:

This feature will mainly focus on “Dataset Terms”, “Restricted Files + Terms of Access” UI implementation.(Guestbook is not implemented for now)

⚠️

  • waiting for backend api to be merged
  • waiting for js-dataverse use case to be merged
  • src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts should be updated with correct use case from js-dataverse
  • should update packages, changelog, merge with dev branch

Which issue(s) this PR closes:

Special notes for your reviewer:

  • make edit terms to be an independent route, which acts differently from JSF
  • for all versions of dataset, the terms information should be the same, and always update to the latest version
  • for mobile viewport of this page, it should become accordion(as the same as JSF) instead of tabs, which looks friendly to mobile users

Suggestions on how to test this:

should be added later

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

yes, should be added later

Is there a release notes or changelog update needed for this change?:

yes, should be added later

@ChengShi-1 ChengShi-1 linked an issue Oct 15, 2025 that may be closed by this pull request
@github-actions github-actions bot added FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) GREI Re-arch GREI re-architecture-related SPA.Q3.2025.3 Dataset Page: Edit Terms SPA: Edit Dataset Page Waiting labels Oct 15, 2025
@ChengShi-1 ChengShi-1 moved this to In Progress 💻 in IQSS Dataverse Project Oct 15, 2025
@ChengShi-1 ChengShi-1 self-assigned this Oct 15, 2025
@ChengShi-1 ChengShi-1 added Size: 10 A percentage of a sprint. 7 hours. Original size: 10 labels Oct 15, 2025
@coveralls
Copy link

Coverage Status

coverage: 98.05% (+0.2%) from 97.837%
when pulling 23d6880 on Edit-term-integration
into c1f5e89 on develop.

@cmbz cmbz added the FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) GREI Re-arch GREI re-architecture-related Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA: Edit Dataset Page SPA.Q3.2025.3 Dataset Page: Edit Terms Waiting

Projects

Status: In Progress 💻

Development

Successfully merging this pull request may close these issues.

Dataset Edit Terms Integration

3 participants