LoginButtonHook: additional buttons below the login form

[Al2Klimov]

No description provided.

[Al2Klimov]

@lippserd Any feedback on the tech side before anyone applies makeup on the buttons?

[Al2Klimov]

This is a minimal hook example I use for testing.

[lippserd]

I know that this is how we do it almost everywhere, but it is not helpful for finding hook usages. I would change the implementation so that we call LoginButtonHook::all().

[lippserd]

Please make the class readonly and use constructor property promotion.

[lippserd]

I would also use logoUri instead of Url.

[lippserd]

If I think about it a little longer, we could make this more flexible by providing ValidHtml $content and ?Attributes $attributes instead of label and logoUri. Then it would be possible to provide either images or icons, as well as other important attributes such as title. What do you think?

[Al2Klimov]

Title can be another property (if you want) and an image is already possible, though unnecessary. IW2 users don't login with Google/ Facebook/ Apple/ ... At best they "Login with id.netways.de". In an actual big company, how many additional login buttons do you expect? Even when 2+, there's text on them saying what they're for.

At most I'd support arbitrary attributes. If we let users add whatever they want, they'll need to style it (CSP friendly) sooner or later, but you said we are responsible for the style of those buttons. Though, users already can style global things using the following hack.

Icinga Web wraps module LESS like this:

/* wrapper */ icinga-module-something {
/* module LESS */ button {
/* module LESS */ color: #234269;
/* module LESS */ }
/* wrapper */ }

Knowing this you can jailbreak:

/* wrapper */ icinga-module-something {
/* module LESS */ }
/* module LESS */ button {
/* module LESS */ color: #234269;
/* module LESS */ }
/* module LESS */ html {
/* wrapper */ }

[lippserd]

I just think we should design the hook so that it works optimally for us and is flexible enough to do everything we want. Therefore, I suggest to use content and attributes and embed the buttons in a module CSS container so that module CSS can be applied to the buttons.

[lippserd]

I would name this form ButtonForm since it is not tied to login, and I would also mark it as readonly and use constructor property promotion.

[Al2Klimov]

In short, Icinga Web 2.13 will require PHP 8.2?

[lippserd]

Sure, why not?

[Al2Klimov]

No why not. Just a clarifying question from my side. :-)