Proto editions #163
Merged
Proto editions #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field is listed ambiguously in https://github.com/InteractiveAdvertisingBureau/openrtb/blob/develop/extensions/community_extensions/Protected%20Audience%20Support.md , but the examples in the lower part of the doc show igi being an array of objects, instead of a single object.
Updated bid_response.ext.igi to be repeated.
Similar to #131 , these two are marked as repeated in the specificaiton. This gets a bit odd as they're also exclusive, which was enforced by the oneof; but oneofs can't be repeated. The exclusive constraint will need to be programatically provided, instead of provided by the protocol.
Similar to #131 and #132 but backwards from previous justifications. In practice this is a json tree that's not wrapped in a string. The examples in https://github.com/InteractiveAdvertisingBureau/openrtb/blob/develop/extensions/community_extensions/Protected%20Audience%20Support.md show this as a string containing json (which is also valid but more recursive than normal). In practice this is more often passed as a json tree inlined in the document itself.
[Protobuf] bid_response.ext.(igb|igs): Removed oneof and added repeated
[Protobuf] Fledge igi.pbs as value instead of string
This includes the IAB block (0-499) the prototype block (500-599) and the Google allocated block.
Corrected the upper bound of the extension range being 999 instead of max. Added Amazon as the 2000 block.
Added a comment block about claiming an extension range.
Whitespace and line length fixes for openrtb.proto.
The great flattening! This outlines many of the nested proto messages into root objects, dramatically reducing the full names of the generated types in some languages. Objects were flattened until they were directly under: * BidRequest * BidResponse * Transparency * NativeRequest * NativeResponse A few objects were not flattened: * Ext messages - They would need to be renamed to include the outer object, and they're supposed to be "inside" the parent object. * BidRequest.EID.UID - The object is small, and moving an object called UID feels real strange to me when that term is massively overloaded. I can outline it if poked. SupplyChainNode was outlined because it contained the entire wrapper class name in its own name, if it was called Node it would not have been outlined.
[Protobuf] The great flattening!
Fixing a typo: Cotent to Content
…es-type Update the type of 'genres'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.