Implemented changes requested in pr #440 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions (microsoft#436) __RESOLVES:__ _feature_ - *Add new CSS color functions* \[[microsoft#305](https://github.com/microsoft/vscode-css-languageservice/issues/305)\] __DESCRIPTION:__ CSS Color Module Level 4 adds support for `oklch` and `oklab` to browsers. They are becoming more popular, and I wanted to use them with color previews in my editor. This feature is built of of the original [microsoft#306](microsoft#306) which included steps for `lab` and `lch` but not the `ok` variants. Generally this code was designed using real world color [examples](https://www.oddcontrast.com/#hex__*f00__*4d216f80__srgb). __STEPS TO TEST:__
* Remove extra characters * trim trailing space in package.json
… of duplicating (microsoft#438) __DESCRIPTION:__ I noticed that both the `tsconfig.json` and the `tsconfig.esm.json` files are largely the same. So it makes sense to me to extend the base on instead of duplicating the configuration options.
* Add basic media query auto complete support * build * Status support * Add `: ` and trigger suggestion * Add test * Only suggest value if not on feature name * Add schema * MediaQuery is not a BodyDeclaration --------- Co-authored-by: Martin Aeschlimann <[email protected]>
…hark chore: bump action and node versions
|
@miss-programgamer Cool. I guess your changes are not yet in microsoft#440 yet. |
|
@aeschli Sure, I'll do that rn |
…geservice into fix/scss-import-node-modules
…e into fix/scss-import-node-modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty of implementing the changes requested by aeschli in pr #440.