Digi live #26
Merged
Digi live #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/jblond/Diff.php # lib/jblond/Diff/Renderer/Text/Unified.php
The example texts are changed so they're clearer about the differences between both version of these text. Also collapsing a block of lines is added to the examples to demonstrate the context option of the Diff class.
258 | VIOLATION | Avoid unused local variables such as '$jKey'.
Closes #24. - As well as the Diff class as the SequenceMatcher class, both have 'trimEqual' added as an option. When set to false, equal lines of text won't be stripped of the start and end of the text. - Re-added long Chinese line to the example and test resources.
- Fixed cli arguments for composer defined script 'phpmd' - Added validation for SequenceMatcher::defaultOptions['context']. - Removed parameter mentioned in docBlock of SequenceMatcher::getGroupedOpCodes(). - Context.php has reduced reduced complexity.
JBlond
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.