Skip to content

fix: EXPOSED-754 Fix global rollback mark not set on unchecked exception in spring transaction #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zbqmgldjfh
Copy link

@zbqmgldjfh zbqmgldjfh commented Apr 1, 2025

Description

Summary of the change:

  • Added a property isRollback managed by TransactionScope in an individual transaction. : SpringTransactionManager
  • Add more test : SpringTransactionRollbackTest

Detailed description:

  • What: Global rollback mark not properly set on Unchecked Exception in Spring Transaction
    tx_flow

  • Why: The issue arises when a method with a transaction is called more than once in a nested manner.
    In this case, the results from the inner transactions are not being propagated to the outer one.
    However, in Spring, it is the default behavior to mark the entire transaction for rollback.
    Even if the exception is caught using a try-catch block, the rollback mark remains.

image (1)
  • How: Add a simple isRollback property for Tx

Type of Change

Please mark the relevant options with an "X":

  • Bug fix
  • New feature
  • Documentation update

Updates/remove existing public API methods:

  • Is breaking change

Affected databases:

  • MariaDB
  • Mysql5
  • Mysql8
  • Oracle
  • Postgres
  • SqlServer
  • H2
  • SQLite

Checklist

  • Unit tests are in place
  • The build is green (including the Detekt check)
  • All public methods affected by my PR has up to date API docs
  • Documentation for my change is up to date

Related Issues

https://youtrack.jetbrains.com/issue/EXPOSED-754/Global-Rollback-Mark-Not-Properly-Set-on-Unchecked-Exception-in-Spring-Transaction

@zbqmgldjfh zbqmgldjfh changed the title fix: EXPOSED-754 Fix Global Rollback Mark Not Set on Unchecked Exception in Spring Transaction fix: EXPOSED-754 Fix global rollback mark not set on unchecked exception in spring transaction Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant