Skip to content

EXPOSED-53 Add test coverage configuration #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

e5l
Copy link
Member

@e5l e5l commented May 14, 2025

Description

Add test coverage tasks for exposed


Type of Change

Please mark the relevant options with an "X":

  • Bug fix
  • New feature
  • Documentation update

Updates/remove existing public API methods:

  • Is breaking change

Affected databases:

  • MariaDB
  • Mysql5
  • Mysql8
  • Oracle
  • Postgres
  • SqlServer
  • H2
  • SQLite

Checklist

  • Unit tests are in place
  • The build is green (including the Detekt check)
  • All public methods affected by my PR has up to date API docs
  • Documentation for my change is up to date

Related Issues

Fix EXPOSED-53 Add coverage configuration

@e5l e5l requested a review from Copilot May 14, 2025 08:16
@e5l e5l self-assigned this May 14, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces test coverage configuration for the Exposed project by integrating the kover plugin in Gradle and updating the project’s documentation.

  • Added kover dependency in gradle/libs.versions.toml
  • Configured kover plugin and test coverage tasks in exposed-tests and exposed-r2dbc-tests build scripts
  • Updated contributing documentation with test coverage report instructions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
gradle/libs.versions.toml Added kover version and dependency definition
exposed-tests/build.gradle.kts Added kover plugin alias and configured test coverage for multiple modules
exposed-r2dbc-tests/build.gradle.kts Added kover plugin alias and test coverage configuration while reordering dependencies for clarity
documentation-website/Writerside/topics/Contributing.md Updated instructions on generating test coverage reports

Comment on lines +31 to +37
kover(project(":exposed-core"))
kover(project(":exposed-jdbc"))
kover(project(":exposed-dao"))
kover(project(":exposed-json"))
kover(project(":exposed-kotlin-datetime"))
kover(project(":exposed-money"))
kover(project(":exposed-migration"))
Copy link
Preview

Copilot AI May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider consolidating the repeated kover(...) calls into a loop or common configuration block to improve readability and reduce duplication.

Suggested change
kover(project(":exposed-core"))
kover(project(":exposed-jdbc"))
kover(project(":exposed-dao"))
kover(project(":exposed-json"))
kover(project(":exposed-kotlin-datetime"))
kover(project(":exposed-money"))
kover(project(":exposed-migration"))
listOf(
":exposed-core",
":exposed-jdbc",
":exposed-dao",
":exposed-json",
":exposed-kotlin-datetime",
":exposed-money",
":exposed-migration"
).forEach { projectName ->
kover(project(projectName))
}

Copilot uses AI. Check for mistakes.

Comment on lines +38 to +40
kover(project(":exposed-core"))
kover(project(":exposed-r2dbc"))
kover(project(":exposed-kotlin-datetime"))
Copy link
Preview

Copilot AI May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The addition of kover configuration is repeated for multiple modules; consider refactoring to minimize repetitive code and enhance maintainability.

Suggested change
kover(project(":exposed-core"))
kover(project(":exposed-r2dbc"))
kover(project(":exposed-kotlin-datetime"))
applyKoverToProjects(":exposed-core", ":exposed-r2dbc", ":exposed-kotlin-datetime")

Copilot uses AI. Check for mistakes.

```shell
docker context use default
```
Exposed project has configures test coverage tasks.
Copy link
Preview

Copilot AI May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider revising the sentence for clarity. A possible correction could be: 'Exposed project now configures test coverage tasks.'

Suggested change
Exposed project has configures test coverage tasks.
Exposed project now configures test coverage tasks.

Copilot uses AI. Check for mistakes.

@e5l e5l force-pushed the e5l/test-coverage branch from c5bd8b1 to e09c3c3 Compare May 19, 2025 11:02
@e5l e5l force-pushed the e5l/test-coverage branch from e09c3c3 to 28e2cd0 Compare May 19, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant