-
Notifications
You must be signed in to change notification settings - Fork 733
EXPOSED-53 Add test coverage configuration #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces test coverage configuration for the Exposed project by integrating the kover plugin in Gradle and updating the project’s documentation.
- Added kover dependency in gradle/libs.versions.toml
- Configured kover plugin and test coverage tasks in exposed-tests and exposed-r2dbc-tests build scripts
- Updated contributing documentation with test coverage report instructions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
gradle/libs.versions.toml | Added kover version and dependency definition |
exposed-tests/build.gradle.kts | Added kover plugin alias and configured test coverage for multiple modules |
exposed-r2dbc-tests/build.gradle.kts | Added kover plugin alias and test coverage configuration while reordering dependencies for clarity |
documentation-website/Writerside/topics/Contributing.md | Updated instructions on generating test coverage reports |
kover(project(":exposed-core")) | ||
kover(project(":exposed-jdbc")) | ||
kover(project(":exposed-dao")) | ||
kover(project(":exposed-json")) | ||
kover(project(":exposed-kotlin-datetime")) | ||
kover(project(":exposed-money")) | ||
kover(project(":exposed-migration")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider consolidating the repeated kover(...) calls into a loop or common configuration block to improve readability and reduce duplication.
kover(project(":exposed-core")) | |
kover(project(":exposed-jdbc")) | |
kover(project(":exposed-dao")) | |
kover(project(":exposed-json")) | |
kover(project(":exposed-kotlin-datetime")) | |
kover(project(":exposed-money")) | |
kover(project(":exposed-migration")) | |
listOf( | |
":exposed-core", | |
":exposed-jdbc", | |
":exposed-dao", | |
":exposed-json", | |
":exposed-kotlin-datetime", | |
":exposed-money", | |
":exposed-migration" | |
).forEach { projectName -> | |
kover(project(projectName)) | |
} |
Copilot uses AI. Check for mistakes.
kover(project(":exposed-core")) | ||
kover(project(":exposed-r2dbc")) | ||
kover(project(":exposed-kotlin-datetime")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The addition of kover configuration is repeated for multiple modules; consider refactoring to minimize repetitive code and enhance maintainability.
kover(project(":exposed-core")) | |
kover(project(":exposed-r2dbc")) | |
kover(project(":exposed-kotlin-datetime")) | |
applyKoverToProjects(":exposed-core", ":exposed-r2dbc", ":exposed-kotlin-datetime") |
Copilot uses AI. Check for mistakes.
```shell | ||
docker context use default | ||
``` | ||
Exposed project has configures test coverage tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider revising the sentence for clarity. A possible correction could be: 'Exposed project now configures test coverage tasks.'
Exposed project has configures test coverage tasks. | |
Exposed project now configures test coverage tasks. |
Copilot uses AI. Check for mistakes.
Description
Add test coverage tasks for exposed
Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues
Fix EXPOSED-53 Add coverage configuration