fix!: Versioning via Version class instead of BigDecimals #2520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obabichevjb
force-pushed
the
obabichev/r2dbc/update-versioning
branch
3 times, most recently
from
50d0e74 to
71bd5fd
Compare
obabichevjb
changed the title
e5l
requested changes
Jun 18, 2025
|
|
||
| import java.math.BigDecimal | ||
|
|
||
| data class Version(val major: Int, val minor: Int, val patch: Int) { |
There was a problem hiding this comment.
Please consider removing the data modifier, and we need to think about extensibility in the minor releases. Could you also check if the constructor should be public?
There was a problem hiding this comment.
I can make it itnernal, but in these case I won't be able to have tests for it in exposed-tests module. Or I can make it @InternalApi, I will stop on this variant for now.
obabichevjb
force-pushed
the
obabichev/r2dbc/update-versioning
branch
2 times, most recently
from
f7b1f78 to
3a30d9d
Compare
obabichevjb
force-pushed
the
obabichev/r2dbc/update-versioning
branch
from
3a30d9d to
b4d086f
Compare
e5l
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace usage of
BigDecimalwith a new classVersionfor database versioning. The current problem is that we store only major/minor versions insideBigDecimalnumber, but ignore patch version.PR introduces a new class
Versionthat stores major, minor and patch versions, and allows to check if one version covers another one.Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods: