Skip to content

Fix DexParser method initialization #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix DexParser method initialization #478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be73e97
Fix DexParser methodIds initialization
wangwillian0 Nov 22, 2025
6139f87
Fix parameter indexing in LSPosedDexParser
wangwillian0 Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/main/java/org/lsposed/lspd/impl/utils/LSPosedDexParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public LSPosedDexParser(@NonNull ByteBuffer buffer, boolean includeAnnotations)

var methodIds = (int[]) out[4];
this.methodIds = new MethodId[methodIds.length / 3];
for (int i = 0; i < this.methodIds.length / 3; ++i) {
for (int i = 0; i < this.methodIds.length; ++i) {
this.methodIds[i] = new LSPosedMethodId(i, methodIds[3 * i], methodIds[3 * i + 1], methodIds[3 * i + 2]);
}

Expand Down Expand Up @@ -176,8 +176,8 @@ class LSPosedProtoId extends LSPosedId<ProtoId> implements ProtoId {
this.returnType = typeIds[protoId[1]];
if (protoId.length > 2) {
this.parameters = new TypeId[protoId.length - 2];
for (int i = 2; i < parameters.length; ++i) {
this.parameters[i] = typeIds[protoId[i]];
for (int i = 0; i < parameters.length; ++i) {
this.parameters[i] = typeIds[protoId[i + 2]];
}
} else {
this.parameters = null;
Expand Down