Skip to content

Commit 96613c1

Browse files
authored
chore: Upgrade ibis to 9.0 (feast-dev#4330)
upgrade ibis version Signed-off-by: tokoko <[email protected]>
1 parent 71afd1c commit 96613c1

File tree

8 files changed

+80
-572
lines changed

8 files changed

+80
-572
lines changed

sdk/python/feast/infra/offline_stores/ibis.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -335,11 +335,8 @@ def deduplicate(
335335
if created_timestamp_col:
336336
order_by_fields.append(ibis.desc(table[created_timestamp_col]))
337337

338-
table = (
339-
table.group_by(by=group_by_cols)
340-
.order_by(order_by_fields)
341-
.mutate(rn=ibis.row_number())
342-
)
338+
window = ibis.window(group_by=group_by_cols, order_by=order_by_fields, following=0)
339+
table = table.mutate(rn=ibis.row_number().over(window))
343340

344341
return table.filter(table["rn"] == ibis.literal(0)).drop("rn")
345342

0 commit comments

Comments
 (0)