Skip to content

Adding default options to as_json method #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2014
Merged

Adding default options to as_json method #1

merged 2 commits into from
Feb 28, 2014

Conversation

bluetwin
Copy link

the JsonApiClient::ResultSet was throwing an exception ArgumentError when calling the as_json

@result = MyApp::Client::SomeClass.where(:type => 'this', :name => 'something').all
render :json => {:my_results => @result}

updated as_json with options defaults.

chingor13 added a commit that referenced this pull request Feb 28, 2014
@chingor13
Merge pull request #1 from bluetwin/as_json_options
06500de 
Adding default options to as_json method
@chingor13 chingor13 merged commit 06500de into JsonApiClient:master Feb 28, 2014
JamesGlover pushed a commit to JamesGlover/json_api_client that referenced this pull request Apr 16, 2020
@jbeast
Merge pull request JsonApiClient#1 from sanger/bad_request
680022f 
Raises an error for bad requests
lannon pushed a commit to lannon/json_api_client that referenced this pull request Oct 15, 2021
@emancu
Merge pull request JsonApiClient#1 from carwow/add_extra_error_classes
c0f2ec2 
Add extra error classes to handle server errors.
raldred pushed a commit to residently/json_api_client that referenced this pull request May 3, 2023
@wcerfgba
Merge pull request JsonApiClient#1 from residently/perf
a8f32fb 
Remove some key_formatter stuff cos we don't use it and it's slow as a dog
raldred pushed a commit to residently/json_api_client that referenced this pull request May 3, 2023
Revert "Merge pull request JsonApiClient#1 from residently/perf"
60405e9 
This reverts commit a8f32fb, reversing
changes made to 526cdee.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluetwin @chingor13