Add find_each #17
Closed
Add find_each #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,5 +44,9 @@ def method_missing(method_name, *args, &block) | |||
| to_a.send(method_name, *args, &block) | |||
| end | |||
|
|
|||
| def find_each(&block) | |||
| Query::FindEach.new(klass, params).call(&block) | |||
There was a problem hiding this comment.
It seems a little odd to make this it's own query class. The class really is just the base/index fetch with methods for doing the iteration. It seems like we could just do that logic here instead of adding an extra layer of abstraction.
|
I refactored that and removed the abstraction. You're right it isn't necessary here. |
|
Don't merge this yet, got another refactor... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.