Skip to content

require addressable/uri #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2015
Merged

require addressable/uri #30

merged 1 commit into from
Mar 23, 2015

Conversation

dplummer
Copy link
Contributor

If you don't require uri, this class is broken.

[1] pry(#<CreditCardsController>)> e
=> #<NameError: uninitialized constant JsonApiClient::Query::Base::Addressable>
[2] pry(#<CreditCardsController>)> e.backtrace
=> ["/Users/dplummer/.rvm/gems/ruby-2.2.0/gems/json_api_client-0.8.0/lib/json_api_client/query/base.rb:19:in `build_path'",
 "/Users/dplummer/.rvm/gems/ruby-2.2.0/gems/json_api_client-0.8.0/lib/json_api_client/query/base.rb:11:in `initialize'",
 "/Users/dplummer/.rvm/gems/ruby-2.2.0/gems/json_api_client-0.8.0/lib/json_api_client/resource.rb:32:in `new'",
 "/Users/dplummer/.rvm/gems/ruby-2.2.0/gems/json_api_client-0.8.0/lib/json_api_client/resource.rb:32:in `find'",

@dplummer
require addressable/uri
b1de877 
If you don't require uri, this class is broken.
chingor13 added a commit that referenced this pull request Mar 23, 2015
@chingor13
Merge pull request #30 from dplummer/patch-1
78a7db1 
require addressable/uri
@chingor13 chingor13 merged commit 78a7db1 into JsonApiClient:master Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dplummer @chingor13