Add writefile to improve compatibility
#381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 89.89% 90.00% +0.10%
==========================================
Files 7 7
Lines 1316 1330 +14
==========================================
+ Hits 1183 1197 +14
Misses 133 133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
quinnj
reviewed
Oct 3, 2025
| """ | ||
| function writefile end | ||
|
|
||
| function writefile(::Type{Vector{UInt8}}, x; pretty::Union{Integer,Bool}=false, kw...) |
There was a problem hiding this comment.
I'm not following why we want this or the 2nd definitions? writefile that doesn't write to a file and just returns a byte vector?
There was a problem hiding this comment.
I want to avoid extra conversions between String and Vector{UInt8} for use with Zarr.jl and SmallZarrGroups.jl
I'm also trying to match the style of the writefile function in Parquet2.jl https://expandingman.gitlab.io/Parquet2.jl/#Writing-Data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
JSON.writefilefunction with the same functionality and keyword arguments as the newJSON.jsonfunction. This function is provided for backward compatibility when upgrading fromolder versions of JSON.jl where the
jsonfunction signature differed.The idea is that
JSON.writefilewill be backported to v0.21.5