Skip to content

Conversation

gnadt
Copy link
Collaborator

@gnadt gnadt commented Jan 19, 2022

Updated the AIA photo, not sure why the images don't have extensions though?

@gnadt gnadt requested a review from emmanuellujan January 19, 2022 16:51
@emmanuellujan emmanuellujan merged commit 0fb5778 into JuliaLabs:master Jan 19, 2022
@emmanuellujan
Copy link
Member

This new version of the image has a wider sky. Please see if you like how it looks when a circle is cropped out of the image (https://julia.mit.edu/research-grants/).

@emmanuellujan
Copy link
Member

As for the extension, the internal project name (in this case AIA) is used as the image name, which saves a column in this table.

@gnadt
Copy link
Collaborator Author

gnadt commented Jan 19, 2022

Yeah I like that better, though a blue background would be even better, I might do that. Oh I meant why don't the images use .png, etc.? (but maybe this is a web dev thing I don't know about)

@emmanuellujan
Copy link
Member

An alternative to loading images with their extension is to use the internal project name (from the table I mentioned) and look in the image directory for the image that has that name, regardless of its extension, and then load that image. Currently it simply takes the internal project name from the table and uses that name to load the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants