-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Avoid depending on Julia-patched libunwind ABI #59266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yeah, I don't think this will work as-is on Windows. |
This already doesn't work on windows (it's behind an ifdef) |
With #58815, using the exe handle may or may not be the right choice depending on the intended behaviour. If we specifically want a version of libuwind depended on by libjulia-internal, we'd need |
Well, I guess we would want to fallback to whatever libjulia-internal thinks libunwind is |
Should this be changed when you dlfind changes? |
Yes, but it'll just require adding a |
8b6e987
to
ae5a7bb
Compare
@gbaraldi did you want this backported to 1.12? |
I'm slightly worried about using the exe handle here. I wonder I should instead do a specific dlopen of libunwind.