Skip to content

RegistryCI: For every version, check that each (weak)compat entry has a corresponding (weak)deps entry #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

RegistryCI: For every version, check that each (weak)compat entry has a corresponding (weak)deps entry #525

wants to merge 12 commits into from

Conversation

DilumAluthge
Copy link
Member

Fixes #522

@DilumAluthge DilumAluthge force-pushed the dpa/every-compat-is-dep branch from 8d731a8 to 31e9292 Compare October 28, 2023 08:10
bors bot added a commit that referenced this pull request Oct 28, 2023
@bors
Try #525:
a5240f9
@JuliaRegistries JuliaRegistries deleted a comment from bors bot Oct 28, 2023
@DilumAluthge DilumAluthge force-pushed the dpa/every-compat-is-dep branch from 7d83570 to fcd704e Compare October 28, 2023 10:58
@DilumAluthge DilumAluthge marked this pull request as ready for review October 28, 2023 11:08
bors bot added a commit that referenced this pull request Oct 28, 2023
@bors
Try #525:
31d438d
@JuliaRegistries JuliaRegistries deleted a comment from bors bot Oct 28, 2023
GunnarFarneback
GunnarFarneback reviewed Oct 28, 2023
View reviewed changes
@DilumAluthge DilumAluthge marked this pull request as draft October 29, 2023 02:06
@DilumAluthge DilumAluthge changed the title Registry consistency tests: For every version, check that each compat entry has a corresponding deps entry Registry consistency tests: For every version, check that each (weak)compat entry has a corresponding (weak)deps entry Oct 29, 2023
bors bot added a commit that referenced this pull request Oct 31, 2023
@bors
Try #525:
e5a60fa
@JuliaRegistries JuliaRegistries deleted a comment from bors bot Oct 31, 2023
@DilumAluthge DilumAluthge marked this pull request as ready for review October 31, 2023 12:19
@DilumAluthge DilumAluthge reopened this Oct 26, 2024
@DilumAluthge
Copy link
Member Author

@GunnarFarneback or @ericphanson Would you be able to review this?

@DilumAluthge
Copy link
Member Author

@ericphanson @GunnarFarneback Can you give this PR another round of review? I'd like to resurrect it and merge it.

@DilumAluthge DilumAluthge changed the title Registry consistency tests: For every version, check that each (weak)compat entry has a corresponding (weak)deps entry RegistryCI: For every version, check that each (weak)compat entry has a corresponding (weak)deps entry Sep 26, 2025
@ericphanson
Copy link
Member

#605 adds some registry unit tests with MetaTesting.jl; we should rebase this PR on top of that one and add additional unit tests to cover this new code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KristofferC KristofferC Awaiting requested review from KristofferC

@fredrikekre fredrikekre Awaiting requested review from fredrikekre

@GunnarFarneback GunnarFarneback Awaiting requested review from GunnarFarneback

@ericphanson ericphanson Awaiting requested review from ericphanson

Assignees

No one assigned

Labels

feature registry consistency tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invariance check that could be added

3 participants

@DilumAluthge @ericphanson @GunnarFarneback