Skip to content

add copy(::StringView) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2023
Merged

add copy(::StringView) #10

merged 1 commit into from
Jan 14, 2023

Conversation

stevengj
Copy link
Member

Just a synonym for String(s), but copy(s) seems like an API people should expect to have.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2023

Codecov Report

Merging #10 (8629830) into main (7c7f0b6) will decrease coverage by 1.35%.
The diff coverage is 21.42%.

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   75.05%   73.70%   -1.36%     
==========================================
  Files           6        6              
  Lines         417      426       +9     
==========================================
+ Hits          313      314       +1     
- Misses        104      112       +8     
Flag Coverage Δ
unittests 73.70% <21.42%> (-1.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/search.jl 44.15% <0.00%> (-5.12%) ⬇️
src/StringViews.jl 96.87% <66.66%> (+0.04%) ⬆️
src/regex.jl 86.76% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stevengj stevengj merged commit f11a2ae into main Jan 14, 2023
@stevengj stevengj deleted the copy branch January 14, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants