Stop pirating Base._searchindex and Base._rsearchindex #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, these methods were extended with new signatures using big unions. These big unions included Base types, which meant that certain methodinstances using concrete types of Base was being invalidated unnecessarily. This PR stops the type piracy, cutting invalidations from 2000 -> 362.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, these methods were extended with new signatures using big unions. These big unions included Base types, which meant that certain methodinstances using concrete types of Base was being invalidated unnecessarily.
This PR stops the type piracy, cutting invalidations from 2000 -> 362 on recent Julia master.
This number of invalidations is much improved compared to Julia 1.8.2 due to recent invalidation hunting.
I think it's still worth investigating why
StringViewscause so many invalidations.Superficial snoop compiling suggests that a blank slate Julia sessions has a lot of abstract methodinstances related to strings compiled, such as
thisind(::AbstractString, ::Int64).If I understand SnoopCompile correctly, this means the problem might be in Base, not in this package.