-
Notifications
You must be signed in to change notification settings - Fork 1
Fix publish job permissions #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe GitHub Actions workflow template was updated to increase sleep durations before package installations from PyPI, enhance import verification by printing the Python version, and grant Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (5)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes missing permissions for the publish job's git tag creation and improves PyPI index update reliability. The primary issue was that the GitHub Actions workflow lacked the necessary contents: write permission to push git tags, causing the publish job to fail.
Key changes:
- Added
contents: writepermission to thecreate-tagjob - Increased PyPI index update wait time from 60s to 90s for better reliability
- Enhanced import test commands to display Python version information
| - name: Confirm library can be imported successfully | ||
| run: python -c "import {% endraw %}{{ package_name | replace('-', '_') }}{% raw %}" | ||
| run: python -c "import sys; print(f'Python version {sys.version}'); import {% endraw %}{{ package_name | replace('-', '_') }}{% raw %}" | ||
|
|
Copilot
AI
Aug 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The Python version print statement adds debugging information but makes the command less focused. Consider separating the version check into a distinct step or making it conditional for cleaner separation of concerns.
Why is this change necessary?
The publish job is currently missing permission to push the git tag
https://github.com/LabAutomationAndScreening/pyalab/actions/runs/16704553688/job/47280840075
How does this change address the issue?
Adds permission
What side effects does this change have?
None
How is this change tested?
Can't until after merge
Other
Also handled #54
Also bumped up the sleep time for PyPI index to populate since there have been cases where 60s was not enough
Summary by CodeRabbit