Add fallback logic to address flags (closes #32) #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements flag fallbacks for Addresses as described in #32
How does it work?
using the magic
__callmethod we are searching the flags defined in config and eventually use them to retrieve the addresses.We can still call methods like
getShippingAddressandgetPrimaryAddress, but instead of using a dedicated method for this we now can utilize thegetAddressByFlagmethod which walks recursively through theflagsarray defined in the config.So if the
flagsarray looks like this:and we are calling
getBillingAddressthe new implementation would walk up the array until it reaches thepublicflag if it cannot find any addresses earlier. It would not check for theshippingflag in this step.After trying all flags and if there is still no address found based on the direction parameter the new implementation would either return the first or the last attached address as a last fallback step.
This ensures to return an address object in almost every situation.