-
Notifications
You must be signed in to change notification settings - Fork 0
feat(core): add Bytes() method to StorageHash interface #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@pcfreak30 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 8 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughThe Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
📒 Files selected for processing (2)
core/storage_hash.go
(3 hunks)go.mod
(3 hunks)
🔇 Additional comments (3)
go.mod (1)
184-186
: Dependency additions look appropriate.The new indirect dependencies for multiformats support are expected when adding CID functionality. These are well-maintained libraries from the IPFS ecosystem.
core/storage_hash.go (2)
7-7
: Import addition looks correct.The import of
github.com/ipfs/go-cid
is appropriate for the new CID byte conversion functionality.
25-25
: Interface extension is well-designed.Adding the
Bytes() []byte
method to theStorageHash
interface provides a clean way to obtain the CID byte representation.
43701b3
to
00d3a40
Compare
- Adds `Bytes()` method to convert StorageHash to CID bytes - Includes necessary `github.com/ipfs/go-cid` dependency - Updates go.mod and go.sum with new dependencies
00d3a40
to
1951e6d
Compare
Bytes()
method to convert StorageHash to CID bytesgithub.com/ipfs/go-cid
dependencySummary by CodeRabbit
New Features
Chores