Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Conversation

@HorayNarea
Copy link
Member

@HorayNarea HorayNarea commented Nov 12, 2017

I couldn't help it, it just seemed to be so much fun… 😁

Of course, this is just a proposal. If you think something is wrong or you don't like the idea of building it in go just tell me, I won't be mad :)

It's a fix for #1 because:

  • RAM-Usage: 3-5 MB instead of >30 MB
  • Docker-Imagesize: ~250 MB instead of >600 MB
  • minimal size (compiled to a single binary): <6 MB

and all that while it's really fast and more flexible and a bit more modular. Yay!

PS: having the dependencies vendored is best-practice in go and I'm not using git-submodules because then it can't build if the initial repo is gone or GitHub has hickups

@kaiyou
Copy link
Member

kaiyou commented Nov 12, 2017

Huh, this is amazing :) thank you so much for contributing. I definitely agree with implementing this in Go, and would even like to go further.

I guess, I will have to learn Go in the next few weeks. I see no reason to maintain the Python version anymore, even if this is not the final form, so let's go.

@kaiyou kaiyou merged commit fa3b363 into Mailu:master Nov 12, 2017
@HorayNarea
Copy link
Member Author

You're welcome! 😊

On the "would even like to go further": learning Go and building a bit more of Mailu in it? 😉
If so: I would like to help you very much, with both!

@kaiyou
Copy link
Member

kaiyou commented Nov 12, 2017

Mmmh, its more of a discussion for our chat channel, but: currently the admin is written in Python and moving to Go would be a huge job. Maybe we could consider it for version 2.0 because that project still requires rewriting most of the admin container.

I am still concerned about completely switching technologies. So, well. Not sure, but it is an option to consider.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants